Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIR][CIRGen][Builtin][Neon] Lower neon_vset_lane_f64 #1253

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

AmrDeveloper
Copy link
Member

Lowering Neon vset_lane_f64

References:
Clang CGBuiltin Implementation
Builtin definition

Copy link
Collaborator

@ghehg ghehg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for working on it. Just a typo.

@AmrDeveloper AmrDeveloper force-pushed the lower_neon_vset_lane_f64 branch from c9b0bb7 to 718ae57 Compare January 2, 2025 17:04
@bcardosolopes
Copy link
Member

Thanks, still needs some conflict resolution and I'll merge it.

@AmrDeveloper
Copy link
Member Author

Thanks, still needs some conflict resolution and I'll merge it.

Thank you, I found a typo (test_vsetq_land_f64 -> test_vsetq_lane_f64) in the previous PR too, I will fix It and resolve the conflict

float64x2_t test_vsetq_land_f64(float64_t a, float64x2_t b) {
return vsetq_lane_f64(a, b, 0);
}
// CIR-LABEL: test_vsetq_land_f64
// CIR: [[IDX:%.*]] = cir.const #cir.int<0> : !s32i
// CIR: {{%.*}} = cir.vec.insert {{%.*}}, {{%.*}}[[[IDX]] : !s32i] : !cir.vector<!cir.double x 2>
// LLVM: {{.*}}test_vsetq_land_f64(double{{.*}}[[A:%.*]], <2 x double>{{.*}}[[B:%.*]])
// LLVM: [[INTRN_RES:%.*]] = insertelement <2 x double> [[B]], double [[A]], i32 0
// LLVM: ret <2 x double> [[INTRN_RES]]

@AmrDeveloper AmrDeveloper force-pushed the lower_neon_vset_lane_f64 branch from 718ae57 to 04f93ed Compare January 6, 2025 15:33
@AmrDeveloper
Copy link
Member Author

@bcardosolopes There is one CI job that failed, i think it's unrelated to the diff

@bcardosolopes bcardosolopes merged commit d1bd77c into llvm:main Jan 6, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants