[RTG] Add context resource attribute interface #8034
+205
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maerhart
force-pushed
the
maerhart-rtg-contextresourceattr
branch
from
8c00f89 to
d439b8c
Compare
maerhart
force-pushed
the
maerhart-rtg-contextresourceattr
branch
from
d439b8c to
bb10af0
Compare
maerhart
commented
Jan 6, 2025
Comment on lines
+42
to
+43
| .def_property_readonly( | ||
| "id", [](MlirAttribute self) { return rtgtestCPUAttrGetId(self); }); |
Comment on lines
+38
to
+46
| /// If the type is an RTGTest CPUAttr. | ||
| MLIR_CAPI_EXPORTED bool rtgtestAttrIsACPU(MlirAttribute attr); | ||
|
|
||
| /// Creates an RTGTest CPU attribute in the context. | ||
| MLIR_CAPI_EXPORTED MlirAttribute rtgtestCPUAttrGet(MlirContext ctxt, | ||
| unsigned id); | ||
|
|
||
| /// Returns the core ID represented by the CPU attribute. | ||
| MLIR_CAPI_EXPORTED unsigned rtgtestCPUAttrGetId(MlirAttribute attr); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a way to specify context resources with an attribute that works well in combination with the ContextResourceTypeInterface. Currently, the
cpu_decloperation has an index attr but returns a ContextResourceTypeInterface type, which makes folding difficult (and thus declaring it ConstantLike).Further down the line, we could consider removing the
ContextResourceOpInterfacein favour of a single op in the RTG dialect.