-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ImportVerilog] Add foreach statement support. #8017
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you can refer to the implementation of Handle repeat loops
. We can pass the cond to the BB1 when we enter. I guess this method can reduce accessing memory(like read
and blokcing_assign
ops) frequently 🤔. WDYT @fabianschuiki?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a few annotations. It's important for others. And thanks for your work on this 😄.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Please wait for @fabianschuiki to review it again.
Add forloop statement support, due to lack of dyn array support, currently static-length array is supported.