Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintenance: Move package.json to the repository root #351

Merged
merged 6 commits into from
Dec 24, 2024
Merged

Conversation

MH4GF
Copy link
Member

@MH4GF MH4GF commented Dec 20, 2024

Description

Move package.json to the repository root. And the associated files are adjusted accordingly.

Motivation

There may be a future when a backend directory is needed, but we can think about that at that time.

Blocking

After the merge of #349, merge this PR after the changeset is gone.

CI Errors

https://github.com/liam-hq/liam/actions/runs/12463106970/job/34784974243?pr=351

It seems that the summary generation fails due to large change differences.
Perhaps we can ignore it and merge it, and there will be no problem with the next PR.

@MH4GF MH4GF had a problem deploying to preview - @liam-hq/erd-sample December 23, 2024 07:33 — with GitHub Actions Error
@MH4GF MH4GF changed the title replace to root maintenance: Move package.json to the repository root Dec 23, 2024
@MH4GF MH4GF changed the title maintenance: Move package.json to the repository root [DO NOT MERGE] maintenance: Move package.json to the repository root Dec 23, 2024
@MH4GF MH4GF marked this pull request as ready for review December 23, 2024 07:55
@MH4GF MH4GF requested a review from a team as a code owner December 23, 2024 07:56
@MH4GF MH4GF requested review from hoshinotsuyoshi, FunamaYukina, junkisai and sasamuku and removed request for a team December 23, 2024 07:56
@MH4GF MH4GF requested a review from masutaka December 23, 2024 07:56
@MH4GF
Copy link
Member Author

MH4GF commented Dec 23, 2024

@masutaka Please your review about CI Errors section!

Copy link
Member

@masutaka masutaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI Errors

https://github.com/liam-hq/liam/actions/runs/12463106970/job/34784974243?pr=351

It seems that the summary generation fails due to large change differences.
Perhaps we can ignore it and merge it, and there will be no problem with the next PR.

You may be a little misguided in your perception. But if a vulnerable package is merged into the main branch, Dependabot alerts will find it. 😄

FYI:
Dependency review only looks at packages that have changed in the diff of a pull request, so the next pull request will not find any problems with this pull request.

.github/workflows/license-frontend.yml Outdated Show resolved Hide resolved
@MH4GF
Copy link
Member Author

MH4GF commented Dec 24, 2024

@masutaka

You may be a little misguided in your perception. But if a vulnerable package is merged into the main branch, Dependabot alerts will find it. 😄

Oh... you are right. It already contained a vulnerable package.
We will be working on a dependency update within the next two weeks!

@masutaka
Copy link
Member

FYI:

It seems that the summary generation fails due to large change differences.

I have subscribed to this issue!

Copy link
Member

@FunamaYukina FunamaYukina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested the app and it's working fine. LGTM!✨

@MH4GF
Copy link
Member Author

MH4GF commented Dec 24, 2024

Thanks for review!
First, merge #349.

@MH4GF MH4GF changed the title [DO NOT MERGE] maintenance: Move package.json to the repository root maintenance: Move package.json to the repository root Dec 24, 2024
@MH4GF MH4GF merged commit 35c7a2b into main Dec 24, 2024
11 of 12 checks passed
@MH4GF MH4GF deleted the replace-to-root branch December 24, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants