Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cibuildwheel will default to manylinux_2_28 on 6th May 2025 - Let's d… #285

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

cibuildwheel will default to manylinux_2_28 on 6th May 2025 - Let's d… #285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
24c53e1
cibuildwheel will default to manylinux_2_28 on 6th May 2025 - Let's d…
HinTak Nov 27, 2024
e06d6ba
The newer Linux has /usr/bin/ninja and does not have python
HinTak Nov 27, 2024
80e4d45
Typo!
HinTak Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
uses: docker/setup-qemu-action@v3
- name: Build skia 3rd-Party
# Taken from https://github.com/pypa/cibuildwheel/blob/v2.19.2/cibuildwheel/resources/pinned_docker_images.cfg
uses: docker://quay.io/pypa/manylinux2014_aarch64:2024.07.02-0
uses: docker://quay.io/pypa/manylinux_2_28_aarch64:2024.07.02-0
if: ${{ steps.cache-skia.outputs.cache-hit != 'true' }}
with:
args: bash -c "git config --global --add safe.directory '*' &&
Expand Down Expand Up @@ -61,7 +61,7 @@ jobs:
- name: Set up QEMU
uses: docker/setup-qemu-action@v3
- name: Build Skia Proper
uses: docker://quay.io/pypa/manylinux2014_aarch64:2024.07.02-0
uses: docker://quay.io/pypa/manylinux_2_28_aarch64:2024.07.02-0
with:
args: bash -c "git config --global --add safe.directory '*' &&
bash scripts/build_Linux.sh
Expand Down Expand Up @@ -116,6 +116,8 @@ jobs:
- name: Build wheels
uses: pypa/[email protected]
env:
CIBW_MANYLINUX_X86_64_IMAGE: manylinux_2_28
CIBW_MANYLINUX_AARCH64_IMAGE: manylinux_2_28
CIBW_BUILD: "${{ matrix.cp }}-*"
CIBW_SKIP: "*musllinux*"
CIBW_ARCHS: ${{ matrix.arch }}
Expand Down Expand Up @@ -179,6 +181,8 @@ jobs:
- name: Build wheels
uses: pypa/[email protected]
env:
CIBW_MANYLINUX_X86_64_IMAGE: manylinux_2_28
CIBW_MANYLINUX_AARCH64_IMAGE: manylinux_2_28
CIBW_BUILD: "${{ matrix.cp }}-*"
CIBW_SKIP: "*musllinux*"
CIBW_ARCHS: ${{ matrix.arch }}
Expand Down
3 changes: 1 addition & 2 deletions scripts/build_Linux.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ if [[ $(uname -m) == "aarch64" ]]; then
yum -y install epel-release && \
yum repolist && \
yum install -y ninja-build && \
ln -s ninja-build /usr/bin/ninja &&
mv depot_tools/ninja depot_tools/ninja.bak
fi

Expand All @@ -54,7 +53,7 @@ fi
git clone https://gn.googlesource.com/gn && \
cd gn && \
git checkout fe330c0ae1ec29db30b6f830e50771a335e071fb && \
python build/gen.py && \
python3 build/gen.py && \
ninja -C out gn && \
cd ..

Expand Down
Loading