Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sk runtime effect binding #274

Merged
merged 77 commits into from
Nov 14, 2024
Merged

Conversation

HinTak
Copy link
Collaborator

@HinTak HinTak commented Oct 23, 2024

Beginning of addressing #269. Include #272 and #267 , but not #273 (that needs tidying).

Runs https://github.com/HinTak/skia-python-examples/blob/main/SkSL_MinifiedSkSL.py . Should run 2 of the 9 examples now.

Refining earlier change (kyamagu#214). It turns out that Xvfb's GL behavior on Linux
differ depending on whether there is actual graphic hardware or entirely
headless. The Apple GL settings works on Xvfb on my computer
(AMD Radeon R5 Graphics), but fails in github headless CI.

Fixes kyamagu#266
Milestone 130
-------------
  * Ganesh files have been moved out of include/gpu/ into include/gpu/ganesh/. Shims have been left in place, but clients should migrate to the new paths.
…was never used

google/skia@16722e4
Revert "Allow passing multiple node IDs per PDF structure node."

    This reverts commit 2a016ba.
    StructureElemementNode::fAdditionalNodeIds is currently unused and
    appears to never have been used.

    Change-Id: If2c1aae88909dc3ec701e94008108e2dc02504bb
    Reviewed-on: https://skia-review.googlesource.com/c/skia/+/905896
…ng icudtl.dat+MakeFromShapedText failure

Conflicts:
	tests/test_font.py
initRuntimeEffect in main()

Needs a default sk_sp<SkRuntimeEffect> holder type for "RuntimeEffect"

Without this, the runtime error is:
    ImportError: generic_type: type "RuntimeEffect" does not have a non-default holder type while its base "SkRefCnt" does
@HinTak HinTak mentioned this pull request Oct 23, 2024
Split CI machinery into two nearly identical sections, one for 3.8/3.9,
another for 3.10 to 3.13. This is mainly due to newer cibuildwheel for
3.13 dropping 3.8 and 3.9, and older cibuildwheel not supporting 3.13.

Fixes kyamagu#230
Split CI machinery into two nearly identical sections, one for 3.8/3.9,
another for 3.10 to 3.13. This is mainly due to newer cibuildwheel for
3.13 dropping 3.8 and 3.9, and older cibuildwheel not supporting 3.13.

Fixes kyamagu#230
@HinTak HinTak mentioned this pull request Oct 25, 2024
@HinTak HinTak requested a review from kyamagu November 6, 2024 22:43
relnotes/README.m132.md Outdated Show resolved Hide resolved
src/skia/RuntimeEffect.cpp Show resolved Hide resolved
tests/test_font.py Outdated Show resolved Hide resolved
@HinTak HinTak mentioned this pull request Nov 13, 2024
…riptor class also

The new header in m132 is "src/ports/SkFontScanner_FreeType_priv.h".
The SkFontDescriptor is possibly useful for accessing the COLRv1 palette
(in my own experimental m129 changes); as is the new SkFontScanner API.
… from the public API.

Milestone 132
-------------
  * `SkPathEffect::DashType`, `SkPathEffect::DashInfo` and `SkPathEffect::asADash` have been removed from the public API.
@HinTak HinTak merged commit db7d7fc into kyamagu:main Nov 14, 2024
1 check passed
@HinTak
Copy link
Collaborator Author

HinTak commented Nov 14, 2024

Ubuntu x86_64 python 3.13:
2147 passed, 102 skipped, 18 xfailed, 27 warnings

Passed gone up a fair amount since m130 because of the new runtime effect tests; xfail up slightly from withdrawal of 3 patheffect.* in m132.

@kyamagu - there are not many interesting changes since you looked at it - m132 (withdrawal of 3 small api from public), and I added a few more overloads to runtime effects and also updated / added some tests. The slightly confusing part is the test changes: there are 3 ways of making runtime effects (for the purpose of making shaders, color filters, and blenders). When you looked at it, I only had tests and examples for the first one. We can't quite provide the last one as we don't even bind SkBlender yet. So the tests are updated for the 2nd case (and the minimal sksl snipplet for each of the three) and the beginning of re-using the created color filter for more interesting usages and tests.

@HinTak
Copy link
Collaborator Author

HinTak commented Nov 14, 2024

Mac os Intel python 3.13, for comparing with m130:
2140 passed, 110 skipped, 18 xfailed, 27 warnings
(I didn't mention ubuntu in m130 due to #266, which is now fixed)

@HinTak HinTak deleted the SkRuntimeEffect-binding branch November 14, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants