Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user can now set http_only and samesite #31

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

henrikac
Copy link
Contributor

@henrikac henrikac commented Oct 4, 2021

This PR adds two additional parameters to the CSRF handler that makes it possible to set httpOnly and SameSite. This is something that was requested in #27 and #28 .

Should close #27, close #28

@henrikac
Copy link
Contributor Author

@sdogruyol just pinging in case you've missed this PR

@sdogruyol
Copy link
Member

Thanks @henrikac , I'm actually waiting on #1 (comment) 😄 What do you think?

@henrikac
Copy link
Contributor Author

henrikac commented Oct 15, 2021

@sdogruyol I like the idea of including it in kemal-session!

I have tried to do this a few times but I keep getting errors saying that some constant has already been set because adding require "kemal-csrf" to kemal-session will set kemal-session constants twice.

@sdogruyol
Copy link
Member

@henrikac which constants are those?

@henrikac
Copy link
Contributor Author

@sdogruyol Kemal::Session::Config::INSTANCE and Kemal::Session::STORABLE_TYPES + some of the macros (if not all of them)

Copy link
Member

@sdogruyol sdogruyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @henrikac 🙏

@sdogruyol sdogruyol merged commit cc24885 into kemalcr:master Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use SameSite Use httpOnly
2 participants