Wagtail 6.3 updates #503
Merged
Wagtail 6.3 updates #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickmoreton
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
nickmoreton
commented
Dec 24, 2024
.github/workflows/test.yml
Outdated
| @@ -11,7 +11,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| python: ["3.8", "3.9", "3.10", "3.11", "3.12"] | |||
| python: ["3.9", "3.10", "3.11", "3.12"] | |||
There was a problem hiding this comment.
I suppose python 3.13 could be added now.
There was a problem hiding this comment.
OK thanks I can update this after the holidays.
There was a problem hiding this comment.
Python 3.13 added here: 9d8bf79
nickmoreton
changed the title
MrCordeiro
reviewed
Dec 28, 2024
MrCordeiro
approved these changes
Dec 28, 2024
There was a problem hiding this comment.
I think this looks great. ❤️
Should we merge it or would you rather include Python 3.13 to the testing matrix first @nickmoreton ?
@MrCordeiro I think this is ready now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes primarily focus on updating the supported versions of Python, Django, and Wagtail, and removing support for older versions and adding some Wagtail version compatibility conditionals.
Updates to testing environment and compatibility:
.github/workflows/test.yml: Removed support for Python 3.8 in the testing matrix.tox.ini: Removed Python 3.8 and Django 3.2 from the environment list and added support for Wagtail 6.3 and Django 5.1. [1] [2]setup.py: Removed Python 3.8 and Django 3.2 from the classifiers and updated thepython_requiresto '>=3.9'.Documentation updates:
README.rst: Updated compatibility information to reflect the removal of Python 3.8 and Django 3.2, and the addition of Django 5.1.CHANGELOG.md: Added an entry for the unreleased changes, including the updates to test Wagtail 6.3 and Django 5.1.Other updates:
I found that using Wagtail 6.3 the templates aren't the best UI and the option to delete a menu was no longer available, the delete button that was previously next to the save button was not available. The delete action link is now in the header bar drop down.
With wagtail 6.3 the snippets have the copy function available by default. As far as I could tell we don't need the copy function for a main menu so I have changed snippet viewset so that
copy_view_enabled = False