Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update locale #844

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Update locale #844

merged 2 commits into from
Jan 7, 2025

Conversation

Andrew-Chen-Wang
Copy link
Member

No description provided.

@Andrew-Chen-Wang Andrew-Chen-Wang requested a review from a team January 7, 2025 00:09
50-Course
50-Course reviewed Jan 7, 2025
View reviewed changes
Copy link
Member

@50-Course 50-Course left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there only appears to be one failing check here:

Run actions/setup-python@v2
Version 3.13 was not found in the local cache

I believe we have to bump it to v4 or v5, which are compatible with python 3.13 (and are contained in cache)

actions/setup-python@v5

@Andrew-Chen-Wang
Copy link
Member Author

thx for the review; updated.

Also found out the i18n action was disabled 💀 Just re enabled it to work on master

@50-Course
Copy link
Member

ah, dependabot already caught it here, we're good 👍🏼 #849

@Andrew-Chen-Wang Andrew-Chen-Wang merged commit 7637f31 into jazzband:master Jan 7, 2025
21 checks passed
@Andrew-Chen-Wang Andrew-Chen-Wang deleted the andrew/update-locale branch January 7, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@50-Course 50-Course 50-Course approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Andrew-Chen-Wang @50-Course