Make CREATE_MISSING_FLAGS logic universal (#400) #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintonb
approved these changes
Mar 3, 2022
clintonb
requested changes
Mar 3, 2022
There was a problem hiding this comment.
@honzakral thanks for the speedy work. Can you add a test for this functionality?
honzakral
force-pushed
the
create-missing-flag
branch
from
fff498f to
35ba0e6
Compare
Before CREATE_MISSING_FLAGS was only respected when `is_active(request)` method was used, now any check against a flag (calling `get(name)`) will trigger the automatic creation of the `Flag` model.
|
@clintonb most of it was covered by existing tests so I just added a simple test that bypasses the current flow and would fail without the patch, hope that helps. If there is any other test you'd like to see I am happy to add it. |
clintonb
approved these changes
Mar 3, 2022
clintonb
added a commit
that referenced
this pull request
Mar 28, 2022
honzakral
added a commit
to honzakral/django-waffle
that referenced
this pull request
Mar 28, 2022
Before CREATE_MISSING_FLAGS was only respected when `is_active(request)` method was used, now any check against a flag (calling `get(name)`) will trigger the automatic creation of the `Flag` model.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before CREATE_MISSING_FLAGS was only respected when
is_active(request)method was used, now any check against a flag (callingget(name)) will trigger the automatic creation of theFlagmodel.Fixes #400