Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AutoLastModifiedField default cache #521

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nesaro
Copy link

@nesaro nesaro commented Mar 18, 2022

Problem

AutoLastModifiedField default cache persists for the life of the instance of the field

Solution

I copied a simplified version of the django implementation that returns the callable value if the default is a callable

Commandments

  • Write PEP8 compliant code.
  • Cover it with tests.
  • Update CHANGES.rst file to describe the changes, and quote according issue with GH-<issue_number>.
  • Pay attention to backward compatibility, or if it breaks it, explain why.
  • Update documentation (if relevant).

@nesaro
Copy link
Author

nesaro commented Mar 18, 2022

The issue seems not to happen if the model is stored in the database; it seems as if there is a second call that to default on write. I updated the test to reflect the condition that makes it fail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant