Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status query managers that inherit methods of a custom queryset #487

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EliasCampos
Copy link

Problem

Please see #486

Solution

In add_status_query_managers signal handler, add creation of manager class, that inherits QueryManager and takes methods of a queryset, returned by .get_queryset() method of a default manager. Status managers, added to a model, are instances of the created manager.

Commandments

  • Write PEP8 compliant code.
  • Cover it with tests.
  • Update CHANGES.rst file to describe the changes, and quote according issue with GH-<issue_number>.
  • Pay attention to backward compatibility, or if it breaks it, explain why.
  • Update documentation (if relevant).

@codecov
Copy link

codecov bot commented Apr 18, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@57d26ee). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #487   +/-   ##
=========================================
  Coverage          ?   94.58%           
=========================================
  Files             ?        6           
  Lines             ?      757           
  Branches          ?        0           
=========================================
  Hits              ?      716           
  Misses            ?       41           
  Partials          ?        0           
Impacted Files Coverage Δ
model_utils/models.py 98.93% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57d26ee...1141d99. Read the comment docs.

@auvipy auvipy requested a review from smithdc1 April 18, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant