[ROCm] Implement RNN support #25755
Open
[ROCm] Implement RNN support #25755
+425
−125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dfm and @superbobry could you please take a look? |
github-actions
bot
force-pushed
the
ci_rnn_final-upstream
branch
from
0b07837 to
36d037e
Compare
superbobry
approved these changes
Jan 8, 2025
| @jax.default_matmul_precision("float32") | ||
| def test_lstm(self, batch_size: int, seq_len: int, input_size: int, | ||
| hidden_size: int, num_layers: int, bidirectional: bool): | ||
| # TODO(phawkins): Partially disable this on cudnn version per b/281071013 | ||
| if (batch_size == 1 and seq_len == 4 and input_size == 1 and | ||
| if jtu.is_device_cuda() and (batch_size == 1 and seq_len == 4 and input_size == 1 and |
There was a problem hiding this comment.
I think we can just nuke this condition since JAX requires cuDNN >=9.1.
| @@ -61,6 +65,7 @@ def test_lstm(self, batch_size: int, seq_len: int, input_size: int, | |||
| weights = rnn.init_lstm_weight(k4, input_size, hidden_size, num_layers, | |||
| bidirectional) | |||
| def f(weights, x, h_0, c_0): | |||
| weights = rnn.swap_lstm_gates(weights, input_size, hidden_size, num_layers, bidirectional) | |||
There was a problem hiding this comment.
How did the test pass without this call before?
google-ml-butler
bot
added
kokoro:force-run
pull ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created from: ROCm#171