-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aten::index_reduce operator #1156
Open
cfgfung
wants to merge
27
commits into
main
Choose a base branch
from
reduce_index_v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+471
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Synced with @xytintel , the difference is small. Will skip those 3 cases. e.g: |
xytintel
reviewed
Jan 6, 2025
xytintel
reviewed
Jan 6, 2025
xytintel
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the index_reduce, index_reduce_ and index_reduce.out operators.
It passes most of the unit tests on the PVC platform except 3 tests. Those failed tests are bf16 and float16.
I checked the differences and found those are small. For example:
Mismatched elements: 1 / 60 (1.7%)
Greatest absolute difference: 0.0625 at index (2, 1, 4) (up to 1e-05 allowed)
Greatest relative difference: 0.001125335693359375 at index (2, 1, 4) (up to 0.001 allowed)
To execute this test, run the following from the base repo dir:
python test/xpu/test_torch_xpu.py
TestTorchDeviceTypeXPU.test_index_reduce_reduce_prod_xpu_float16
I suspect the software emulation of the atomic operations of those low-level precisions causes that. Shall we skip those tests?
Need inputs from @xytintel and @fengyuan14
Side note: This function is in beta and may change in the near future. (Ref - https://pytorch.org/docs/stable/generated/torch.Tensor.index_reduce_.html)