-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update npm lockfile to v3 #68
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've had a read through all the lines in this PR and it LGTM. 👌
But worth getting at least one other person to approve before merging. 💭
CC: @indexzero 🤞
73c92dc
to
b99219a
Compare
b99219a
to
c00df69
Compare
The CI runs also confirm that it works.
Are there currently any other active maintainers for this repo apart from yourself? |
@MikeMcC399 good question. I don't have visibility of the access to the repo so can't say. 🤷♂️ |
If there is no response from @indexzero I will assume that this package is no longer maintained. Merging changes into the default branch is only useful if there is a means to release a new package to the npm registry at an appropriate time.
|
There hasn't been any feedback from @indexzero so far, so the outlook for maintaining this repo does not look good. |
@MikeMcC399 maybe look at what Charlie has been contributing to 🔍 {
"dependencies": {
"ps-tree": "https://github.com/yourname/ps-tree-2025"
}
} Ref: https://www.warp.dev/terminus/npm-install-from-github I know that doesn't work for packages that depend on |
Thank you for your New Year's wishes! The same to you too! As far as the participation of the owner of the repo is concerned, unless they respond themselves here, at least with a short note, there is no way of knowing whether they are temporarily or permanently absent. Any assumptions are speculation. Since this PR itself is trivial and easily set up again, I am going to close it now due to lack of progress and uncertain outcome. |
Issue
The npm lockfile package-lock.json uses the outdated
"lockfileVersion": 1
.npm documentation for lockfileversion shows the lockfile version as follows:
npm is bundled with Node.js. The Node.js release schedule shows that Node.js 18 to 23 are currently supported.
The package-lock.json lockfile is committed to the repository, however it is never published as part of the npm package. It is only used by Contributors and CI workflows.
The workflow ci-test.yml runs with a minimum npm
v10.8.2
according to workflow logs, so lockfile version 3 should be used.Change
"lockfileVersion": 1
to"lockfileVersion": 3
.npm audit fix
to fix critical vulnerabilities in locked versions