fix: update typesVersion field spec to match docs
#3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It could be good to check that the keys of the |
|
Seems like because I updated the dependencies, it pulls in a newer version of dprint in which something in the current config doesn't work, making the |
|
Thanks for the PR. I'll take a look now. |
ifiokjr
reviewed
Oct 6, 2023
| @@ -66,8 +66,8 @@ pub struct PackageJson { | |||
| #[builder(default, setter(into, strip_option))] | |||
| pub version: Option<String>, | |||
|
|
|||
| /// Version must be parseable by node-semver, which is bundled with npm as a | |||
| /// dependency. | |||
| /// Put a description in it. It's a string. | |||
ifiokjr
reviewed
Oct 6, 2023
Cargo.toml
Outdated
| validator = { version = "0.16", features = ["derive"], optional = true } | ||
| proc-macro2 = "1.0.66" |
There was a problem hiding this comment.
That's leftover of me trying to fix the CI checks. I'll tidy things up shortly.
|
@ifiokjr PR cleaned up and ready for review |
ifiokjr
approved these changes
Sep 25, 2024
ifiokjr
changed the title
typesVersion field spec to match docs
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! The library is throwing errors on valid documented usage of the
typesVersionsfield, so this fixes that.[Documentation so
(also, I added therustfmt.tomlfile to make all future contributions respect your indent style)