Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'ADD --checksum' support #92

Merged
merged 6 commits into from
Apr 24, 2024
Merged

Conversation

ppettina
Copy link
Contributor

This PR adds support for the --checksum flag in the ADD instruction:
https://docs.docker.com/engine/reference/builder/#verifying-a-remote-file-checksum-add---checksumchecksum-http-src-dest

Note, I know nothing about the Haskell programming language - I have written this by looking at this other PR #84. So please be kind!

Final goal would be to add another rule to Hadolint recommending the use of ADD --checksum with remote sources.

@ppettina ppettina changed the title Add checksum Add 'ADD --checksum' support Jan 30, 2024
@ppettina
Copy link
Contributor Author

Ping @lorenzo :)

@mkesper
Copy link

mkesper commented Apr 8, 2024

Does anyone here know how to work around this until this issue gets fixed? This does not seem like an error that can be ignored with inline comments in the Dockerfile.

@ppettina
Copy link
Contributor Author

ppettina commented Apr 8, 2024

Does anyone here know how to work around this until this issue gets fixed? This does not seem like an error that can be ignored with inline comments in the Dockerfile.

We forked the hadolint repository internally, then put the content of this repo (language-docker) with this PR merged in vendored/language-docker (a full copy), then rebuilt as per step 2 in https://github.com/hadolint/hadolint?tab=readme-ov-file#setup.

@lorenzo lorenzo merged commit 52ca2e5 into hadolint:master Apr 24, 2024
3 of 4 checks passed
@lorenzo
Copy link
Member

lorenzo commented Apr 24, 2024

thanks!

@ppettina ppettina deleted the add-checksum branch November 6, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants