http2: dial retry should respect to request timeout

golang · Jun 4, 2024 · f520097 · f520097
1 parent 5ac0f0e
commit f520097
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/http2/client_conn_pool.go b/http2/client_conn_pool.go
@@ -94,9 +94,13 @@ func (p *clientConnPool) getClientConn(req *http.Request, addr string, dialOnMis
 		traceGetConn(req, addr)
 		call := p.getStartDialLocked(req.Context(), addr)
 		p.mu.Unlock()
-		<-call.done
-		if shouldRetryDial(call, req) {
-			continue
+		select {
+		case <-call.done:
+			if shouldRetryDial(call, req) {
+				continue
+			}
+		case <-req.Context().Done():
+			return nil, req.Context().Err()
 		}
 		cc, err := call.res, call.err
 		if err != nil {