Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syscall/syscall_windows: add ERROR_INVALID_NAME to oserror.ErrNotExist #71108

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pzx521521
Copy link

@pzx521521 pzx521521 commented Jan 3, 2025

The following is an example of checking if a file exists:

stat, err := os.Stat("http://www.google.com")
if os.IsNotExist(err) {
//.....
}

On macos/linux it works perfectly,os.IsNotExist(err) return true

func (e Errno) Is(target error) bool {
//.....
	case oserror.ErrNotExist:
		return e == ENOENT
//.....

In windows, os.IsNotExist(err) return false
an ERROR_INVALID_NAME error will appear.
it was not an ErrNotExist error before.

func (e Errno) Is(target error) bool {
//.....
	case oserror.ErrNotExist:
		return e == ERROR_FILE_NOT_FOUND ||
			e == _ERROR_BAD_NETPATH ||
			e == ERROR_PATH_NOT_FOUND ||
			//e == ERROR_INVALID_NAME ||
			e == ENOENT
//.....
  • Moved the declaration of the variable ERROR_INVALID_NAME
    • ERROR_INVALID_NAME is not used in this pakage src/internal/syscall/windows/syscall_windows.go
  • ERROR_INVALID_NAME is also an oserror.ErrNotExist error

1.Moved the declaration of the variable ERROR_INVALID_NAME

2.ERROR_INVALID_NAME is also an Errno error
@pzx521521 pzx521521 changed the title ERROR_INVALID_NAME syscall/syscall_windows: ERROR_INVALID_NAME is oserror.ErrNotExist also Jan 3, 2025
@pzx521521 pzx521521 changed the title syscall/syscall_windows: ERROR_INVALID_NAME is oserror.ErrNotExist also syscall/syscall_windows: ERROR_INVALID_NAME can also be considered as a type of oserror.ErrNotExist error Jan 3, 2025
@pzx521521 pzx521521 changed the title syscall/syscall_windows: ERROR_INVALID_NAME can also be considered as a type of oserror.ErrNotExist error syscall/syscall_windows: ERROR_INVALID_NAME is a type of oserror.ErrNotExist Jan 3, 2025
@pzx521521 pzx521521 changed the title syscall/syscall_windows: ERROR_INVALID_NAME is a type of oserror.ErrNotExist syscall/syscall_windows: ERROR_INVALID_NAME is oserror.ErrNotExist Jan 3, 2025
@gopherbot
Copy link
Contributor

This PR (HEAD: 148fe75) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/639975.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@pzx521521 pzx521521 changed the title syscall/syscall_windows: ERROR_INVALID_NAME is oserror.ErrNotExist syscall/syscall_windows: add ERROR_INVALID_NAME to oserror.ErrNotExist Jan 3, 2025
@pzx521521 pzx521521 changed the title syscall/syscall_windows: add ERROR_INVALID_NAME to oserror.ErrNotExist syscall/syscall_windows: add ERROR_INVALID_NAME to oserror.ErrNotExist Jan 3, 2025
@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/639975.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Para Peng:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/639975.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ingo Oeser:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/639975.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Para Peng:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/639975.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants