-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔥 feat: Add Context Support to RequestID Middleware #3200
Merged
ReneWerner87
merged 15 commits into
gofiber:main
from
JIeJaitt:jiejaitt-feature/add-user-context-support
Nov 15, 2024
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
12daef3
Rename UserContext() to Context(). Rename Context() to RequestCtx()
gaby 3ea6695
feat: add requestID in UserContext
JIeJaitt a5dc68d
Merge branch 'main' of github.com:JIeJaitt/fiber into jiejaitt-featur…
JIeJaitt 8d13eb7
Merge branch 'main' of github.com:gofiber/fiber into jiejaitt-feature…
JIeJaitt 022d3c7
Update Ctxt docs and What's new
gaby 8d7015d
Merge branch 'main' into fix-3186
gaby a6f7a16
Remove extra blank lines
gaby 83cf164
Merge branch 'fix-3186' of github.com:gofiber/fiber into jiejaitt-fea…
JIeJaitt 44479ad
♻️ Refactor: merge issue #3186
JIeJaitt 69bd6ee
🔥 Feature: improve FromContext func and test
JIeJaitt 0709b65
📚 Doc: improve requestid middleware
JIeJaitt 0ba6c17
Merge branch 'main' into jiejaitt-feature/add-user-context-support
gaby 0781d02
♻️ Refactor: Rename interface to any
JIeJaitt 0e31b2f
Merge branch 'main' of github.com:gofiber/fiber into jiejaitt-feature…
JIeJaitt 869beb2
fix: Modify structure sorting to reduce memory usage
JIeJaitt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix potential race condition and add cleanup.
There are several issues in the test execution:
ctxVal
variable is shared between parallel test executions, which could lead to race conditionsHere's how to fix these issues: