Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the links for languages by pointing to the full list directly #35811

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

Fryguy
Copy link
Contributor

@Fryguy Fryguy commented Jan 2, 2025

Why:

Closes: N/A

What's being changed (if available, include any code snippets, screenshots, or gifs):

The list of languages here is a subset of the full list available elsewhere. Instead of trying to keep it up to date, we can point to that full list directly. This prevents having to keep this list up to date in the future. Additionally, now this section is more consistent with the other sections in this document which also point the reader elsewhere. As a small bonus the old links were pointing to a link that no longer exists directly and was instead a redirect, so this is now pointing to a living page.

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require a SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing.

The list of languages here is a subset of the full list available
elsewhere. Instead of trying to keep it up to date, we can point
to that full list directly. This prevents having to keep this list up to
date in the future. Additionally, now this section is more consistent
with the other sections in this document which also point the reader
elsewhere. As a small bonus the old links were pointing to a link that
no longer exists directly and was instead a redirect, so this is now
pointing to a living page.
Copy link

welcome bot commented Jan 2, 2025

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jan 2, 2025
Copy link
Contributor

github-actions bot commented Jan 2, 2025

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/migrating-to-github-actions/manually-migrating-to-github-actions/migrating-from-travis-ci-to-github-actions.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836
Copy link
Contributor

@Fryguy Thanks so much for opening a PR! I'll get this triaged for review ✨

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Jan 2, 2025
Copy link
Contributor

@subatoi subatoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for this change, @Fryguy — we're always happy to see anything that simplifies our docs in an effective way like this. We're frozen until later today so I'll approve this now and let my colleague @nguyenalex836 go ahead and merge it later.

@subatoi subatoi added the ready to merge This pull request is ready to merge label Jan 3, 2025
@nguyenalex836
Copy link
Contributor

@Fryguy I believe we might actually be frozen until Monday, but we'll be sure to merge as soon as the freeze lifts 💛

@nguyenalex836 nguyenalex836 removed the waiting for review Issue/PR is waiting for a writer's review label Jan 6, 2025
@nguyenalex836 nguyenalex836 added this pull request to the merge queue Jan 6, 2025
Merged via the queue into github:main with commit a494a7b Jan 6, 2025
46 checks passed
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@Fryguy Fryguy deleted the simplify_languages_links branch January 6, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants