Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seats not active in 30 days #136

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Seats not active in 30 days #136

merged 1 commit into from
Jan 8, 2025

Conversation

karpikpl
Copy link
Collaborator

@karpikpl karpikpl commented Jan 5, 2025

This pull request includes several changes to the SeatsAnalysisViewer.vue component to enhance its functionality and improve code readability. The most important changes include updating the display logic for seat analysis, modifying the data structure for seat counts, and refining the component's styling.

image

Display Logic Updates:

  • Updated the display logic to show the number of seats with no activity in the last 7 and 30 days, and the number of seats never used. This change involved adding new computed properties and updating the template to reflect these counts. [1] [2] [3]

Data Structure Modifications:

  • Changed the data structure for seat counts from arrays to numerical values for better performance and clarity. The properties noshowSeats, unusedSeatsInSevenDays, and unusedSeatsInThirtyDays were introduced to replace the previous array-based approach.

Styling Refinements:

  • Adjusted the styling of the v-card elements to ensure consistent margins and widths, improving the overall visual alignment of the tiles. [1] [2]

Code Cleanup:

  • Removed unnecessary imports and variables to streamline the codebase and improve readability.

@karpikpl karpikpl requested a review from Copilot January 5, 2025 06:22

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

src/components/SeatsAnalysisViewer.vue:132

  • [nitpick] The variable name 'noshowSeats' should be 'noShowSeats' for better readability and consistency with JavaScript naming conventions.
const noshowSeats = ref<number>(0);

src/components/SeatsAnalysisViewer.vue:179

  • Ensure that the new behavior for counting 'noShowSeats', 'unusedSeatsInSevenDays', and 'unusedSeatsInThirtyDays' is covered by tests.
noshowSeats.value = noshowCount;
@karpikpl
Copy link
Collaborator Author

karpikpl commented Jan 5, 2025

Replaces #101

@karpikpl karpikpl merged commit 692012c into main Jan 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants