Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to node20 #688

Merged
merged 7 commits into from
Nov 14, 2023
Merged

Switch to node20 #688

merged 7 commits into from
Nov 14, 2023

Conversation

dscho
Copy link
Member

@dscho dscho commented Nov 13, 2023

This fixes #684

@dscho dscho self-assigned this Nov 13, 2023
GitHub has deprecated node.js 16 and requires node Actions to migrate to
version 20 by "spring 2024". [1] Update to node.js 20 to avoid
deprecation warnings.

This fixes git-for-windows#684

[1]
https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

Signed-off-by: Johannes Schindelin <[email protected]>
This does not resolve any current problems, but it's always good not to
stay too far behind.

Signed-off-by: Johannes Schindelin <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
Now that this Action uses node.js 20, it's time to update the
workflow definition so that the `action/checkout` steps also use node.js 20.

Signed-off-by: Johannes Schindelin <[email protected]>
Now that this Action uses node.js 20, let's also use it in the steps of
the CI builds which use `github-script`.

Signed-off-by: Johannes Schindelin <[email protected]>
@dscho
Copy link
Member Author

dscho commented Nov 14, 2023

@rimrul I rebased it after prematurely merging #689, to resolve the merge conflicts, sorry for the noise!

@dscho dscho merged commit d6c7daa into git-for-windows:main Nov 14, 2023
3 checks passed
@dscho dscho deleted the switch-to-node20 branch November 14, 2023 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to node20
2 participants