Update aliases judgment for winpty #553
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
only use aliases when disable pseudo console instead of case $TERM Signed-off-by: E. H. <[email protected]>
Please sign off the commit, not the PR: Add your sign-off to the commit message. But if you use a pseudonym and a non-working email address, then it is not actually a sign-off. |
dscho
reviewed
Apr 25, 2024
Comment on lines
-8
to
+9
| case "$TERM" in | ||
| xterm*) | ||
| case "$MSYS" in | ||
| *disable_pcon*) |
There was a problem hiding this comment.
The trouble with this is: by default MSYS is unset, and Pseudo Console support is still disabled. The new check misses that rather common scenario, and therefore will break them.
I did not find a way to reliably determine whether Pseudo Console support is enabled. We may need to patch the MSYS2 runtime to be able to tell, first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mintty can change their type of $TERM easily in settings, it's better use
disable_pconto get winpty aliases.Signed-off-by: E. H [email protected]