Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI issues #538

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Fix CI issues #538

merged 2 commits into from
Dec 14, 2023

Conversation

dscho
Copy link
Member

@dscho dscho commented Dec 14, 2023

One issue was noticed in #537, the other I noticed while in the area.

In git-for-windows#537, the GitHub
workflow failed because the `result` output was inadvertently spelled in
its plural form, which does not work.

Fix that.

Signed-off-by: Johannes Schindelin <[email protected]>
There was a broken `&&` chain here. I ❤️ the ease of error handling in
shell scripts</s>.

Signed-off-by: Johannes Schindelin <[email protected]>
@dscho dscho self-assigned this Dec 14, 2023
@dscho dscho force-pushed the fix-ci-issues branch 4 times, most recently from a72c5d5 to dd03967 Compare December 14, 2023 15:13
@dscho dscho marked this pull request as ready for review December 14, 2023 15:13
@dscho dscho requested a review from rimrul December 14, 2023 15:13
@dscho
Copy link
Member Author

dscho commented Dec 14, 2023

Here is proof that the problem we saw in git-for-windows/build-extra#536 is fixed.

@dscho dscho merged commit 15b05c2 into git-for-windows:main Dec 14, 2023
6 checks passed
@dscho dscho deleted the fix-ci-issues branch December 14, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants