Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mingw-w64-git-credential-manager: update to 2.4.1 #533

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

gitforwindowshelper[bot]
Copy link

@rimrul rimrul marked this pull request as ready for review November 2, 2023 12:07
@rimrul
Copy link
Member

rimrul commented Nov 2, 2023

/deploy

The workflow run was started.

@dscho
Copy link
Member

dscho commented Nov 2, 2023

@rimrul This symptom is the same as of this failure:

BUG: wrapper.c:680: your snprintf is broken

I am in the process of investigating a working-around; My guess is that mingw-w64-x86_64-gettext changed how it handles libintl_vsnprintf(), and that the newer version returns values that Git's core contributors consider "bogus".

@dscho
Copy link
Member

dscho commented Nov 2, 2023

My guess is that mingw-w64-x86_64-gettext changed how it handles libintl_vsnprintf()

Indeed. Fuller analysis: msys2/MINGW-packages#18983 (comment).

I think we'll need to pin mingw-w64-gettext to known-good versions for now.

@dscho
Copy link
Member

dscho commented Nov 2, 2023

/add relnote

The workflow run was started

@dscho dscho merged commit 188236a into main Nov 2, 2023
6 of 7 checks passed
@dscho dscho deleted the mingw-w64-git-credential-manager-2.4.1 branch November 2, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New git-credential-manager version] GCM 2.4.1
2 participants