Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces foundational changes to enhance chat template functionality in the Llama Android project. While the core functionality has been implemented, integration with the main application flow is pending and will be addressed in future updates.
Added JNI Support:
llama-android.cpp
.Updated LlamaAndroid.kt:
List<Map<String, String>>
) for structured message handling.Refactored MainViewModel.kt:
messages
to be a list instead of a string:Pending Integration:
applyChatTemplate
function is created but not yet invoked in the application flow.Benefits
Testing
MainViewModel.kt
.applyChatTemplate
tested with sample data.To-Do
applyChatTemplate
into the main application flow.applyChatTemplate
inLlamaAndroid.kt
.Reviewer Notes
applyChatTemplate
function are appreciated.