Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): add snapshot test to landing page #1274

Closed
wants to merge 4 commits into from

Conversation

shootermv
Copy link
Contributor

@shootermv shootermv commented Dec 30, 2024

Summary of changes

learned recently about interesting feature of playwright tool - the snapshot tests.
snapshot tests means - it should compare the screenshot done in the past with screenshot after current change visually

Checklist

  • I have read and followed the contribution guidelines.
  • I have read through the Code of Conduct and agree to abide by the rules.
  • This PR is for one of the available issues and is not a PR for an issue already assigned to someone else.
  • My PR title has a short descriptive name so the maintainers can get an idea of what the PR is about.
  • I have provided a summary of my changes.

closes #XXXXX

@shootermv shootermv force-pushed the add-e2e-snapshot-test branch 8 times, most recently from 6e12b58 to 986c5e8 Compare December 31, 2024 15:34
@shootermv shootermv force-pushed the add-e2e-snapshot-test branch from 986c5e8 to f629846 Compare December 31, 2024 15:42
@huyenltnguyen
Copy link
Member

Thank you for the PR.

Screenshot testing is definitely useful for visual regression testing. However, the Developer Quiz project is quite small and simple, and we want to allow some flexibility in visual display (being able to adjust the UI without too much friction). The additional tooling also comes with maintenance cost, and given the scale of the project, we decided to not proceed with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants