[Heatmap] Adjusting grid calcualtion for consistent grid layout #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Date math is hard! This addresses a problem in how the heatmap lays calculates days to lay out the grid. The calculations were being thrown off in some scenarios by a combination of factors including timezone offsets, time of day, and daylight savings time. This patch should correct all this by forcing each day to be midnight UTC when laying out the grid.
|
@kimili Could you send this to |
Date math is hard! This addresses a problem in how the heatmap lays calculates days to lay out the grid. The calculations were being thrown off in some scenarios by a combination of factors including timezone offsets, time of day, and daylight savings time. This patch should correct all this by forcing each day to be midnight UTC when laying out the grid.
# Conflicts: # dist/frappe-charts.min.cjs.js # dist/frappe-charts.min.cjs.js.map # dist/frappe-charts.min.esm.js # dist/frappe-charts.min.esm.js.map # dist/frappe-charts.min.iife.js # dist/frappe-charts.min.iife.js.map # docs/assets/js/frappe-charts.min.js # docs/assets/js/frappe-charts.min.js.map # docs/assets/js/index.min.js # docs/assets/js/index.min.js.map # package-lock.json
|
@pratu16x7 - Done. The minimized build files reflect those in |
This was referenced Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation About What Code Achieves:
This addresses a problem in how the heatmap lays calculates days to lay out the grid. The calculations were being thrown off in some scenarios by a combination of factors including timezone offsets, time of day, and daylight savings time.
This patch should correct all this by forcing each day to be midnight UTC when laying out the grid.
Date math is hard!
Steps To Test:
Refer to #157 - This patch should address the problems outlined there.