Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rephrase mentoring request prompts #6825

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Rephrase mentoring request prompts #6825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ring-session/mentoring-request/MentoringRequestFormComponents/SolutionCommentTextArea.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export const SolutionCommentTextArea = React.forwardRef<
>((_, ref) => (
<div className="question">
<label htmlFor="request-mentoring-form-solution-comment">
How can a mentor help you with this solution?
About your solution
</label>
<p id="request-mentoring-form-solution-description">
Give your mentor a starting point for the conversation. This will be your
Expand Down
4 changes: 1 addition & 3 deletions ...ring-session/mentoring-request/MentoringRequestFormComponents/TrackObjectivesTextArea.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,7 @@ export const TrackObjectivesTextArea = React.forwardRef<
{ defaultValue: string; track: Pick<MentorSessionTrack, 'title'> }
>(({ track, defaultValue }, ref) => (
<div className="question">
<label htmlFor="request-mentoring-form-track-objectives">
What are you hoping to learn from this track?
</label>
<label htmlFor="request-mentoring-form-track-objectives">About you</label>
<p id="request-mentoring-form-track-description">
Tell our mentors a little about your programming background and what
you&apos;re aiming to learn from {track.title}.
Expand Down
2 changes: 1 addition & 1 deletion test/system/flows/edit_solution_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ class EditSolutionTest < ApplicationSystemTestCase
refute_text "Checking for automated feedback"
assert_text "No Immediate Feedback"
click_on "Request code review"
assert_text "What are you hoping to learn from this track?"
assert_text "About you"

input_1 = find("#request-mentoring-form-track-objectives")
input_2 = find("#request-mentoring-form-solution-comment")
Expand Down
12 changes: 6 additions & 6 deletions test/system/flows/student_requests_mentorship_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ class StudentRequestsMentorship < ApplicationSystemTestCase
first("button", text: "Select an exercise").click
within(".m-select-exercise-for-mentoring") { click_on "Lasagna" }

fill_in "What are you hoping to learn from this track?", with: "I want to learn OOP."
fill_in "How can a mentor help you with this solution?", with: "I'm sorry but I have absolutely no idea."
fill_in "About you", with: "I want to learn OOP."
fill_in "About your solution", with: "I'm sorry but I have absolutely no idea."
click_on "Submit mentoring request"
end

Expand Down Expand Up @@ -72,8 +72,8 @@ class StudentRequestsMentorship < ApplicationSystemTestCase
first("button", text: "Select an exercise").click
within(".m-select-exercise-for-mentoring") { click_on "Lasagna" }

fill_in "What are you hoping to learn from this track?", with: "12345678901234567890"
fill_in "How can a mentor help you with this solution?", with: "1234567890123456789"
fill_in "About you", with: "12345678901234567890"
fill_in "About your solution", with: "1234567890123456789"

click_on "Submit mentoring request"

Expand All @@ -83,8 +83,8 @@ class StudentRequestsMentorship < ApplicationSystemTestCase
refute_text "Waiting on a mentor…"
refute_text "12345678890123456789"

fill_in "What are you hoping to learn from this track?", with: "1234567890123456789"
fill_in "How can a mentor help you with this solution?", with: "12345678901234567890"
fill_in "About you", with: "1234567890123456789"
fill_in "About your solution", with: "12345678901234567890"

click_on "Submit mentoring request"

Expand Down
Loading