Remove duplicate before_install section in .travis.yml #15581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I added the script to install html-tidy I accidentally created a second, duplicate, `before_install` section. Because of the way YAML works this silently overwrote the other `before_install` section which was setting the contents of `.netrc` so that git had some credentials to use to deploy. This change combines the two sections into one.
tmtmtmtm
approved these changes
Sep 27, 2016
|
A little digging around led me to ruby/psych#79 (comment) which suggests using https://github.com/adrienverge/yamllint. That's written in python but should be possible to get it running on Travis (it would be nice if Travis could spit out a warning but oh well!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
This removes a duplicate
before_installsection from.travis.ymlthat I accidentally added in #15573.Why was this needed?
Deploys of everypolitician.org were failing because I'd overwritten the
before_installsection that was adding credentials to.netrc, so git didn't have the correct credentials available to push to viewer-static.Relevant Issue(s)
#15573 was the pull request that introduced the problem.