Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix matching creation bytecode "perfect" when the creation bytecode does not have CBOR not at end #1839

Open
wants to merge 4 commits into
base: staging
Choose a base branch
from
Open

Fix matching creation bytecode "perfect" when the creation bytecode does not have CBOR not at end #1839

wants to merge 4 commits into from

Conversation

kuzdogan
Copy link
Member

@kuzdogan kuzdogan commented Jan 7, 2025

Fixes #1769 refer there.

I also needed to change the localhost of the local Hardhat network to 127.0.0.1. For some reason this was not working on my setup.

Also added two test cases

@manuelwedler manuelwedler self-assigned this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuelwedler manuelwedler manuelwedler left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@manuelwedler manuelwedler

Labels
None yet
Projects
Sourcify Public
Status: Sprint - Needs Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix creation bytecode perfect matching
2 participants
@kuzdogan @manuelwedler