Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test amoc_metrics #7

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Test amoc_metrics #7

merged 1 commit into from
Dec 3, 2024

Conversation

NelsonVides
Copy link
Collaborator

@NelsonVides NelsonVides commented Dec 3, 2024

Prometheus would crash when creating a metric if it doesn't declare a help string.

@NelsonVides NelsonVides force-pushed the prometheus branch 2 times, most recently from b353dca to c4ecde6 Compare December 3, 2024 08:01
@NelsonVides NelsonVides changed the title Add a very simple check for amoc_metrics Test amoc_metrics Dec 3, 2024
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👌

@chrzaszcz chrzaszcz merged commit 312bd22 into main Dec 3, 2024
2 checks passed
@chrzaszcz chrzaszcz deleted the prometheus branch December 3, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants