Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/module app/set module version #2685

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Conversation

eikeland
Copy link
Contributor

@eikeland eikeland commented Jan 7, 2025

Added versioning support to AppModuleProvider.

Modified files:

  • packages/modules/app/src/AppModuleProvider.ts

Changes:

  • Imported SemanticVersion from @equinor/fusion-framework-module.
  • Imported version from ./version.
  • Added a version getter to AppModuleProvider that returns a SemanticVersion instance.

Copy link

changeset-bot bot commented Jan 7, 2025

🦋 Changeset detected

Latest commit: a0452ab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@equinor/fusion-framework-module-app Patch
@equinor/fusion-framework-app Patch
@equinor/fusion-framework-react-app Patch
@equinor/fusion-framework-legacy-interopt Patch
poc-portal Patch
@equinor/fusion-framework-cookbook-app-react-context-custom-error Patch
@equinor/fusion-framework-cookbook-app-react-context Patch
@equinor/fusion-framework-cookbook-app-react-feature-flag Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added 🐞 bug Something isn't working 🚧 chore maintaines work, (update deps, workflos ...) 🧬 Modules labels Jan 7, 2025
@eikeland eikeland marked this pull request as ready for review January 7, 2025 09:06
@eikeland eikeland requested review from odinr and a team as code owners January 7, 2025 09:06
@eikeland eikeland self-assigned this Jan 7, 2025
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 0.37% 1746 / 462656
🔵 Statements 0.37% 1746 / 462656
🔵 Functions 22.93% 205 / 894
🔵 Branches 36.93% 386 / 1045
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/modules/app/src/AppModuleProvider.ts 0% 0% 0% 0% 1-183
Generated in workflow #8263 for commit a0452ab by the Vitest Coverage Report Action

@odinr odinr merged commit add2e98 into main Jan 9, 2025
9 of 10 checks passed
@odinr odinr deleted the fix/module-app/set-module-version branch January 9, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 🚧 chore maintaines work, (update deps, workflos ...) 🧬 Modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants