Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle unopenable files consistently in config #9682

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Jan 8, 2025

Issue
Resolves #9681

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

Copy link

codspeed-hq bot commented Jan 8, 2025

CodSpeed Performance Report

Merging #9682 will not alter performance

Comparing eivindjahren:fix_read_file (071daa0) with main (71e38f2)

Summary

✅ 24 untouched benchmarks

@eivindjahren eivindjahren added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Jan 9, 2025
@eivindjahren eivindjahren force-pushed the fix_read_file branch 2 times, most recently from 32266f7 to 8f251b1 Compare January 9, 2025 08:37
@eivindjahren eivindjahren self-assigned this Jan 9, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.74%. Comparing base (383d645) to head (071daa0).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9682      +/-   ##
==========================================
- Coverage   91.74%   91.74%   -0.01%     
==========================================
  Files         426      426              
  Lines       26518    26553      +35     
==========================================
+ Hits        24328    24360      +32     
- Misses       2190     2193       +3     
Flag Coverage Δ
cli-tests 39.66% <60.86%> (-0.04%) ⬇️
everest-models-test 34.18% <43.47%> (-0.04%) ⬇️
gui-tests 74.32% <60.86%> (+2.37%) ⬆️
integration-test 38.01% <43.47%> (-0.06%) ⬇️
performance-tests 51.70% <60.86%> (+0.05%) ⬆️
test 39.53% <52.17%> (-0.06%) ⬇️
unit-tests 74.25% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

Installing a workflow you do not have permissions to results in unhandled exception
2 participants