Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor BaseRunModel #9676

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

frode-aarstad
Copy link
Contributor

Issue
Resolves #9604

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@frode-aarstad frode-aarstad added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Jan 8, 2025
@frode-aarstad frode-aarstad self-assigned this Jan 8, 2025
@frode-aarstad frode-aarstad force-pushed the refactor-baserunmodel branch 2 times, most recently from 95a4211 to a049423 Compare January 8, 2025 09:16
Copy link

codspeed-hq bot commented Jan 8, 2025

CodSpeed Performance Report

Merging #9676 will degrade performances by 15.33%

Comparing frode-aarstad:refactor-baserunmodel (4b764b8) with main (383d645)

Summary

❌ 1 regressions
✅ 23 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main frode-aarstad:refactor-baserunmodel Change
test_load_from_context[gen_x: 20, sum_x: 20 reals: 10] 6 ms 7.1 ms -15.33%

@frode-aarstad frode-aarstad force-pushed the refactor-baserunmodel branch from a049423 to 4b764b8 Compare January 8, 2025 10:49
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.73%. Comparing base (383d645) to head (4b764b8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9676      +/-   ##
==========================================
- Coverage   91.74%   91.73%   -0.01%     
==========================================
  Files         426      426              
  Lines       26518    26553      +35     
==========================================
+ Hits        24328    24359      +31     
- Misses       2190     2194       +4     
Flag Coverage Δ
cli-tests 39.79% <87.23%> (+0.08%) ⬆️
everest-models-test 34.26% <62.50%> (+0.04%) ⬆️
gui-tests 71.96% <80.85%> (+0.01%) ⬆️
integration-test 38.09% <64.58%> (+0.03%) ⬆️
performance-tests 51.68% <72.34%> (+0.03%) ⬆️
test 39.63% <64.58%> (+0.03%) ⬆️
unit-tests 74.28% <85.41%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove ErtConfig from the BaseRunModel
2 participants