Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#![no_std] Compatibility #150

Closed
wants to merge 1 commit into from
Closed

#![no_std] Compatibility #150

wants to merge 1 commit into from

Conversation

zer0x64
Copy link

@zer0x64 zer0x64 commented Apr 24, 2020

The changes allows the crate to be used with #![no_std].

The use case is described here:
rust-fuzz/arbitrary#38

@zer0x64 zer0x64 marked this pull request as draft April 24, 2020 16:47
@zer0x64
Copy link
Author

zer0x64 commented Apr 24, 2020

I converted this back to a Draft after realizing that making the tests pass was not enough

dtolnay
dtolnay reviewed Apr 24, 2020
View reviewed changes
Copy link
Owner

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arbitrary_derive is a proc macro crate so it's only compiled for the host and will use std even if the target is no-std, so I don't think we need this for your use case.

@dtolnay dtolnay closed this Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zer0x64 @dtolnay