Add unit tests for DesignerFrame #12712
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12712 +/- ##
===================================================
+ Coverage 75.75455% 76.03633% +0.28178%
===================================================
Files 3159 3165 +6
Lines 635942 639539 +3597
Branches 46987 47257 +270
===================================================
+ Hits 481755 486282 +4527
+ Misses 150726 149697 -1029
- Partials 3461 3560 +99
Flags with carried forward coverage won't be shown. Click here to find out more. |
| MethodInfo? invalidateOverlaysMethod = overlayControlType?.GetMethod("InvalidateOverlays", [typeof(Region)]); | ||
| invalidateOverlaysMethod.Should().NotBeNull(); | ||
|
|
||
| using (var region = new Region(new Rectangle(25, 25, 50, 50))) |
There was a problem hiding this comment.
Please declare variables explicitly with a type. This happens again a few lines below.
| MethodInfo? invalidateOverlaysMethod = overlayControlType?.GetMethod("InvalidateOverlays", [typeof(Region)]); | ||
| invalidateOverlaysMethod.Should().NotBeNull(); | ||
|
|
||
| using (var region = new Region(new Rectangle(25, 25, 50, 50))) |
There was a problem hiding this comment.
Please declare variables explicitly with a type. This happens again a few lines below.
| designerFrame.Controls.Cast<Control>().Should().NotContain(control); | ||
| } | ||
|
|
||
| [Fact] |
There was a problem hiding this comment.
This PR provides thorough testing for the OverlayControl class. However, since OverlayControl is a private class fully encapsulated within the DesignerFrame class (the actual target of this PR), it cannot be accessed directly outside of DesignerFrame.
Testing OverlayControl here relies heavily on reflection, which we typically avoid in unit tests.
An alternative approach could involve recreating OverlayControl within the test class, but given its size and complexity, this may introduce significant overhead for testing an inner private class.
At this stage, it might be more practical to focus on testing DesignerFrame's more exposed properties and methods, deferring OverlayControl-specific tests for a future refactor.
What do you think @lonitra @Tanya-Solyanik ?
Example of how tests could go:
[Fact]
public void Designer_ProcessDialogKey()
{
Mock<ISite> mockSite = new(); // Consider making this a field if reused
using DesignerFrame designerFrame = new(mockSite.Object); // Same for this if used across methods
bool result = designerFrame.TestAccessor().Dynamic.ProcessDialogKey(Keys.Enter);
result.Should().BeFalse();
}
ricardobossan
added
the
📭 waiting-author-feedback
Related #10773
Proposed changes
Microsoft Reviewers: Open in CodeFlow