Use Unsafe.BitCast in SpanHelprs.Fill
#111091
Conversation
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-memory |
xtqqczze
force-pushed
the
use-unsafe-bitcast
branch
from
fe6f0ed to
1eb387c
Compare
xtqqczze
force-pushed
the
use-unsafe-bitcast
branch
from
1eb387c to
7ec2876
Compare
xtqqczze
force-pushed
the
use-unsafe-bitcast
branch
from
7ec2876 to
93e46f0
Compare
| ? (Vector<byte>)(new Vector<double>((double)(object)tmp!)) | ||
| : (Vector<byte>)(new Vector<ulong>(Unsafe.As<T, ulong>(ref tmp))); | ||
| ? (Vector<byte>)(new Vector<double>(Unsafe.BitCast<T, double>(value))) | ||
| : (Vector<byte>)(new Vector<ulong>(Unsafe.BitCast<T, ulong>(value))); |
There was a problem hiding this comment.
Is this method reachable for e.g. int??
The conditions above look like they'd let it use the vectorized path, but BitCast doesn't work with nullable.
Hopefully that should be caught by tests?
There was a problem hiding this comment.
this whole thing could really be simplified to just return Vector.Create<T>(value).As<T, byte>();
There was a problem hiding this comment.
All of these throw a NotSupportedException at runtime for Nullable<int>, we have to keep using Unsafe.As, unfortunately.
| Vector<byte> vector; | ||
|
|
||
| if (sizeof(T) == 1) | ||
| { | ||
| vector = new Vector<byte>(Unsafe.As<T, byte>(ref tmp)); | ||
| vector = new Vector<byte>(Unsafe.BitCast<T, byte>(value)); |
There was a problem hiding this comment.
This and a similar suggestion for most other paths:
| vector = new Vector<byte>(Unsafe.BitCast<T, byte>(value)); | |
| vector = Vector.Create<T>(value).As<T, byte>(); |
There was a problem hiding this comment.
The paths could likely just all be collapsed to a single if (...) block as well if using the above pattern, notably
This reverts commit 93e46f0.
xtqqczze
changed the title
Unsafe.BitCast to avoid taking addressUnsafe.BitCast in SpanHelprs.Fill
No description provided.