[release/9.0-staging] [mono] [llvm-aot] Fixed storing Vector3 into memory #111069
+47
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
fanyang-mono and
steveisok
as code owners
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
jkurdek
added
area-Codegen-LLVM-mono
and removed
area-CodeGen-coreclr
jkurdek
requested review from
matouskozak and
tannergooding
and removed request for
fanyang-mono
|
Tagging subscribers to this area: @steveisok, @vitek-karas |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jan 3, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #111000 to release/9.0-staging
Customer Impact
Reported in #110820.
Regression
Regression introduced in #97416
Testing
Added test a new test verifying that saving Vector3 works correctly.
Risk
Low. Change applies only to mono aot llvm Vector3 save to memory path.
Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.