Baseline more pri1 tests with native AOT #111068
Open
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I originally thought this found a real bug but this is just a really weird test exercising not just slow delegate creation path, but also quite invalid IL: https://github.com/dotnet/runtime/blob/3d88f276b13ae4d2ffa6a66b02f32171fdc825b5/src/tests/JIT/Methodical/delegate/_simpleoddpower.il#L510-L517 (Notice that despite the newobj, the actual object instance is of a completely different type and the method is not on that type.)
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
Should we delete this test instead? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally thought this found a real bug but this is just a really weird test exercising not just slow delegate creation path, but also quite invalid IL:
runtime/src/tests/JIT/Methodical/delegate/_simpleoddpower.il
Lines 510 to 517 in 3d88f27
(Notice that despite the newobj, the actual object instance is of a completely different type and the method is not on that type, took a while to realize the newobj is useless and unrelated.)
Cc @dotnet/ilc-contrib