Drop container-interop/container-interop
#729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am aware of the failing tests, I will address these in a bit. |
|
seem good to me 🥇 |
Indeed, we need to bump laminas-servicemanager to the version introducing class aliases for the interop and the Psr containers. For the records, boesing has explained this here: php-fig/container#37 Please bump to ^3.17.0. Otherwise this PR looks fine. |
…servicemanager` This drops the abandoned `Interop\Container\ContainerInterface` interface in favour of `Psr\Container\ContainerInterface`. To ensure that the signature change for `CliConfigurator` does not break anything, we also bump `laminas/laminas-servicemanager` to `3.17.0` in order to ensure that class aliases for the Interop and Psr containers exist.
The Laminas `AdapterInterface` is absolutely not restrictive of the type of the items that can be in the paginator's collection. However, here the incorrect Psalm type was used. The `DoctrinePaginator` expects an `object` (typed as `T`), such as `Doctrine\ORM\Tools\Pagination\Paginator`. However, this `T` is not the correct type for the items in the paginator.
`CliConfigurator::getHelpers()` should always return.
I have amended my first commit to bump the version to ensure correct history. Thank you for your time taking a look at this :) |
driehle
approved these changes
Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #728 this drops the abandoned
container-interop/container-interopin favour ofpsr/container. This means that theInterop\Container\ContainerInterfaceinterface is replaced withPsr\Container\ContainerInterface.Unlike doctrine/DoctrineModule#792 not all changed signatures are in
finalclasses, specifically theCliConfigurator. This may require bumpinglaminas/laminas-servicemanagerto at leastv3.11.0, @driehle please advise.