Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: not disable ally test rule anymore #3640

Merged
merged 7 commits into from
Jan 6, 2025
Merged

refactor: not disable ally test rule anymore #3640

merged 7 commits into from
Jan 6, 2025

Conversation

mfranzke
Copy link
Member

@mfranzke mfranzke commented Jan 3, 2025 •
edited
Loading

Proposed changes

Adds some aspects for #3332

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke mfranzke added 🐛bug Something isn't working 👂accessibility Accessibility issues/improvements labels Jan 3, 2025
@mfranzke mfranzke self-assigned this Jan 3, 2025
@mfranzke mfranzke linked an issue Jan 3, 2025 that may be closed by this pull request
refactor: not disable aria_attribute_valid anymore #3332
Closed
@mfranzke mfranzke added 🧪test Improvements/bugs for testing-framework and removed 🐛bug Something isn't working labels Jan 3, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/3332-refactor-not-disable-aria_attribute_valid-and-color-contrast-anymore

@github-actions github-actions bot added 🏘components Changes inside components folder 📺showcases Changes to 1-n showcases labels Jan 3, 2025
@mfranzke mfranzke enabled auto-merge (squash) January 3, 2025 12:21
@mfranzke mfranzke changed the title refactor: not disable color-contrast rule anymore refactor: not disable ally test rules anymore Jan 3, 2025
@mfranzke mfranzke changed the title refactor: not disable ally test rules anymore refactor: not disable ally test rule anymore Jan 3, 2025
@mfranzke mfranzke removed their assignment Jan 4, 2025
@mfranzke mfranzke requested a review from nmerget January 6, 2025 08:01
@mfranzke mfranzke merged commit 50fb338 into main Jan 6, 2025
73 checks passed
@mfranzke mfranzke deleted the 3332-refactor-not-disable-aria_attribute_valid-and-color-contrast-anymore branch January 6, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerget nmerget nmerget approved these changes

@annsch annsch Awaiting requested review from annsch annsch is a code owner

@bruno-sch bruno-sch Awaiting requested review from bruno-sch bruno-sch is a code owner

Assignees
No one assigned
Labels
👂accessibility Accessibility issues/improvements 🏘components Changes inside components folder 📺showcases Changes to 1-n showcases 🧪test Improvements/bugs for testing-framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor: not disable aria_attribute_valid anymore
2 participants
@mfranzke @nmerget