feat: convert to whitelabel #3616
Open
+2,918
−3,239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
📕documentation
|
🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/feat-whitelabel |
mfranzke
reviewed
Dec 19, 2024
Co-authored-by: Maximilian Franzke <[email protected]>
# Conflicts: # __snapshots__/foundations/chromium/Colors-should-match-screenshot-1/Colors-should-match-screenshot.png # __snapshots__/foundations/chromium/Fonts-should-match-screenshot-1/Fonts-should-match-screenshot.png # __snapshots__/foundations/chromium/Icons-should-match-screenshot-1/Icons-should-match-screenshot.png # __snapshots__/foundations/firefox/Colors-should-match-screenshot-1/Colors-should-match-screenshot.png # __snapshots__/foundations/firefox/Fonts-should-match-screenshot-1/Fonts-should-match-screenshot.png # __snapshots__/foundations/firefox/Icons-should-match-screenshot-1/Icons-should-match-screenshot.png # __snapshots__/foundations/webkit/Colors-should-match-screenshot-1/Colors-should-match-screenshot.png # __snapshots__/foundations/webkit/Fonts-should-match-screenshot-1/Fonts-should-match-screenshot.png # __snapshots__/foundations/webkit/Icons-should-match-screenshot-1/Icons-should-match-screenshot.png # __snapshots__/input/patternhub/input-docs-should-match-screenshot.png # __snapshots__/input/showcase/webkit/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png
mfranzke
reviewed
Jan 6, 2025
| @@ -9,7 +9,7 @@ | |||
| | 🔄 renamed `Tonality` to `Density` | class names and data-attributes changed from <br/>`.db-ui-#{$tonality},[data-tonality="#{$tonality}"] {` to <br/>`.db-#{density},[data-density="#{density}"] {` | search `tonality` & replace with `density` | | |||
| | ❌ removed `opacity` tokens | we use only 1 opacity (0.4) for all components | If you use some of the tokens like `--db-opacity-sm` you might run into issues with your layout | | |||
| | 🔄 updated `border` tokens | we add all shirt-sizes `3xs`-`3xl` as tokens | If you use some of the tokens like `db-border-height-sm` you might run into issues with your layout, because the values behind it changed | | |||
| | 🔄 moved `_font-sizes.scss` | We moved the file to another folder to align the same structure as icons or colors. We add `css` classes, you can use them by importing `@db-ui/foundations/scss/fonts/classes/all.css` | If you use some placeholder like `%db-overwrite-font-size-sm` you might need to import the `_font-sizes.scss` like this: `@use "@db-ui/foundations/build/scss/fonts";` | | |||
| | 🔄 moved `_font-sizes.scss` | We moved the file to another folder to align the same structure as icons or colors. We add `css` classes, you can use them by importing `@db-ui/foundations/scss/fonts/classes/all.css` | If you use some placeholder like `%db-overwrite-font-size-sm` you might need to import the `_font-sizes.scss` like this: `@use "@db-ui/foundations/build/styles/fonts";` | | |||
There was a problem hiding this comment.
Suggested change
| | 🔄 moved `_font-sizes.scss` | We moved the file to another folder to align the same structure as icons or colors. We add `css` classes, you can use them by importing `@db-ui/foundations/scss/fonts/classes/all.css` | If you use some placeholder like `%db-overwrite-font-size-sm` you might need to import the `_font-sizes.scss` like this: `@use "@db-ui/foundations/build/styles/fonts";` | | |
| | 🔄 moved `_font-sizes.scss` | We moved the file to another folder to align the same structure as icons or colors. We add `css` classes, you can use them by importing `@db-ui/foundations/scss/fonts/classes/all.css` | If you use some placeholder like `%db-overwrite-font-size-sm` you might need to import the `_font-sizes.scss` like this: `@use "@db-ui/foundations/build/scss/fonts";` | |
At the time of writing (this file), this has been the correct path.
|
@nmerget huger changes like this would need some new chapter within the migration guide (at least as a preparation for an upcoming release). |
mfranzke
reviewed
Jan 6, 2025
| ``` | ||
|
|
||
| </details> | ||
|
|
||
| > **Note:** The `db-ui-42` file contains optional and all components styles. If you consider performance issues see [@db-ui/components](https://www.npmjs.com/package/@db-ui/components) for more information. | ||
| > **Note:** The `relative` file contains optional and all components styles. If you consider performance issues see [@db-ui/components](https://www.npmjs.com/package/@db-ui/components) for more information. |
There was a problem hiding this comment.
Suggested change
| > **Note:** The `relative` file contains optional and all components styles. If you consider performance issues see [@db-ui/components](https://www.npmjs.com/package/@db-ui/components) for more information. | |
| > **Note:** The `@db-ui/components/build/styles/relative` file contains optional and all components styles. If you consider performance issues see [@db-ui/components](https://www.npmjs.com/package/@db-ui/components) for more information. |
I think that for clarity it makes sense to include the full path to this instead of just the filename itself.
mfranzke
reviewed
Jan 6, 2025
| ``` | ||
|
|
||
| </details> | ||
|
|
||
| > **Note:** The `db-ui-42` file contains optional and all components styles. If you consider performance issues see [@db-ui/components](https://www.npmjs.com/package/@db-ui/components) for more information. | ||
| > **Note:** The `relative` file contains optional and all components styles. If you consider performance issues see [@db-ui/components](https://www.npmjs.com/package/@db-ui/components) for more information. |
There was a problem hiding this comment.
Suggested change
| > **Note:** The `relative` file contains optional and all components styles. If you consider performance issues see [@db-ui/components](https://www.npmjs.com/package/@db-ui/components) for more information. | |
| > **Note:** The `@db-ui/components/build/styles/relative` file contains optional and all components styles. If you consider performance issues see [@db-ui/components](https://www.npmjs.com/package/@db-ui/components) for more information. |
I think that for clarity it makes sense to include the full path to this instead of just the filename itself.
mfranzke
reviewed
Jan 6, 2025
| ``` | ||
|
|
||
| </details> | ||
|
|
||
| > **Note:** The `db-ui-42` file contains optional and all components styles. If you consider performance issues see [@db-ui/components](https://www.npmjs.com/package/@db-ui/components) for more information. | ||
| > **Note:** The `relative` file contains optional and all components styles. If you consider performance issues see [@db-ui/components](https://www.npmjs.com/package/@db-ui/components) for more information. |
There was a problem hiding this comment.
Suggested change
| > **Note:** The `relative` file contains optional and all components styles. If you consider performance issues see [@db-ui/components](https://www.npmjs.com/package/@db-ui/components) for more information. | |
| > **Note:** The `@db-ui/components/build/styles/relative` file contains optional and all components styles. If you consider performance issues see [@db-ui/components](https://www.npmjs.com/package/@db-ui/components) for more information. |
I think that for clarity it makes sense to include the full path to this instead of just the filename itself.
mfranzke
reviewed
Jan 6, 2025
There was a problem hiding this comment.
why has this file been removed ?
mfranzke
reviewed
Jan 6, 2025
| preset: [ | ||
| 'default', | ||
| { | ||
| svgo: false |
There was a problem hiding this comment.
do you disable this here, because we're already running svgo within the icon repo ?
mfranzke
reviewed
Jan 6, 2025
|
|
||
| `db-ui-42` bundles all dependencies from [foundations](https://www.npmjs.com/package/@db-ui/foundations) + all [components](https://github.com/db-ui/mono/blob/main/packages/components/src/styles/db-ui-components.scss) available. | ||
| They are bundling all dependencies from [foundations](https://www.npmjs.com/package/@db-ui/foundations) + all [components](https://github.com/db-ui/mono/blob/main/packages/components/src/styles/db-ui-components.scss) available. |
There was a problem hiding this comment.
Suggested change
| They are bundling all dependencies from [foundations](https://www.npmjs.com/package/@db-ui/foundations) + all [components](https://github.com/db-ui/mono/blob/main/packages/components/src/styles/db-ui-components.scss) available. | |
| They are bundling all dependencies from [foundations](https://www.npmjs.com/package/@db-ui/foundations) and all [components](https://github.com/db-ui/mono/blob/main/packages/components/src/styles/db-ui-components.scss) available. |
accessibility (understandability)
mfranzke
reviewed
Jan 6, 2025
Comment on lines
+33
to
+35
| - relative: asset path point to `../assets` | ||
| - webpack: asset path point to `~@db-ui/foundations/assets` | ||
| - rollup: asset path point to `@db-ui/foundations/assets` |
There was a problem hiding this comment.
Suggested change
| - relative: asset path point to `../assets` | |
| - webpack: asset path point to `~@db-ui/foundations/assets` | |
| - rollup: asset path point to `@db-ui/foundations/assets` | |
| - `relative`: asset path point to `../assets` | |
| - `webpack`: asset path point to `~@db-ui/foundations/assets` | |
| - `rollup`: asset path point to `@db-ui/foundations/assets` |
mfranzke
reviewed
Jan 6, 2025
| @@ -0,0 +1,15 @@ | |||
| /* This is a predefined beginner friendly bundle with default asset-paths (../assets) */ | |||
There was a problem hiding this comment.
Suggested change
| /* This is a predefined beginner friendly bundle with default asset-paths (../assets) */ | |
| /* This is a predefined beginner friendly bundle with default asset-paths (../assets) */ |
❤️
mfranzke
reviewed
Jan 6, 2025
| @@ -0,0 +1,12 @@ | |||
| @use "internal/custom-elements"; | |||
|
|
|||
| // wc-workaround | |||
There was a problem hiding this comment.
Suggested change
| // wc-workaround | |
| // Web Components workaround |
Not everybody might be familiar that we mean Web Components by the short "wc" phrase. So we should probably do another change for adapting these to the full phrase for clarity both within the comments as well as in the filenames.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Types of changes
Further comments