refactor(CI/CD): replace shell script by JavaScript #3454
+216
−101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfranzke
added
🍄🆙improvement
|
🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/refactor-cicd-replace-shell-by-javascript |
mfranzke
changed the title
nmerget
reviewed
Jan 6, 2025
| @@ -0,0 +1,65 @@ | |||
| import fs from 'node:fs'; | |||
| import path from 'node:path'; | |||
| import tar from 'tar'; | |||
There was a problem hiding this comment.
Do we have this dependency in our package.json?
nmerget
reviewed
Jan 6, 2025
|
|
||
| console.log('📥 Get gh-pages tar'); | ||
| fetch(`https://github.com/${OWNER_NAME}/${REPO_NAME}/tarball/gh-pages`) | ||
| .then((res) => { |
There was a problem hiding this comment.
We should use async & await here, instead of multiple then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
replaced pipeline shell scripts by JavaScript files.
tested within the pipeline with https://github.com/db-ui/mono/releases/tag/v0.6.3-5
Types of changes
Further comments