Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: not disable aria_attribute_valid anymore #3332

Closed
mfranzke opened this issue Oct 18, 2024 · 0 comments · Fixed by #3640
Closed

refactor: not disable aria_attribute_valid anymore #3332

mfranzke opened this issue Oct 18, 2024 · 0 comments · Fixed by #3640
Labels
👂accessibility Accessibility issues/improvements 🍄🆙improvement New feature or request

Comments

@mfranzke
Copy link
Member

mfranzke commented Oct 18, 2024 •
edited
Loading 

          we would need to investigate why we need to disable `aria_attribute_valid` afterwards fix the problem in general.

plus color-contrast for axe

Originally posted by @mfranzke in #3174 (comment)
@mfranzke mfranzke mentioned this issue Oct 18, 2024
Merged
5 tasks
@mfranzke mfranzke changed the title refactor: not disable aria_attribute_valid anymore refactor: not disable aria_attribute_valid and color-contrast anymore Oct 18, 2024
@mfranzke mfranzke added 🍄🆙improvement New feature or request 👂accessibility Accessibility issues/improvements labels Oct 18, 2024
@mfranzke mfranzke added this to the v0.6.0 milestone Oct 18, 2024
@mfranzke mfranzke removed this from the v0.6.0 milestone Oct 27, 2024
@mfranzke mfranzke linked a pull request Jan 3, 2025 that will close this issue
refactor: not disable ally test rule anymore #3640
Merged
5 tasks
@mfranzke mfranzke mentioned this issue Jan 3, 2025
Merged
5 tasks
@mfranzke mfranzke changed the title refactor: not disable aria_attribute_valid and color-contrast anymore refactor: not disable aria_attribute_valid and ~color-contrast~ anymore Jan 3, 2025
@mfranzke mfranzke changed the title refactor: not disable aria_attribute_valid and ~color-contrast~ anymore refactor: not disable aria_attribute_valid and ~~color-contrast~~ anymore Jan 3, 2025
@mfranzke mfranzke changed the title refactor: not disable aria_attribute_valid and ~~color-contrast~~ anymore refactor: not disable aria_attribute_valid anymore Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
👂accessibility Accessibility issues/improvements 🍄🆙improvement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: not disable ally test rule anymore db-ui/mono
1 participant
@mfranzke