-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update performance benchmarks #3818
base: v1.12
Are you sure you want to change the base?
Conversation
Signed-off-by: yaron2 <[email protected]>
daprdocs/content/en/operations/performance-and-scalability/perf-actors-activation.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a link to the Actor performance test that we can include, so that people can try this themselves?
|
||
### Kubernetes performance test setup | ||
|
||
The test was conducted on a 3 node Kubernetes cluster, using commodity hardware running 4 cores and 8GB of RAM, without any network acceleration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a link to the performance test that we can include, so that people can try this themselves?
|
||
<img src="/images/perf_invocation_p99.png" alt="Latency for 99th percentile"> | ||
This performance is on par or better than commonly used service meshes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's quantify this with a link to service meshes perf results, otherwise this is hearsay and we should not include this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In removing the graphs, there is not mTLS measurement comparison. What impact does mTLS have on the performance tests, it would be good to at least clarify this with a % increase. The majority of people will use mTLS and so this number is important.
daprdocs/content/en/operations/performance-and-scalability/perf-service-invocation.md
Show resolved
Hide resolved
| Sentry | 0.005 | 13.6 Mb | ||
| Sidecar Injector | 0.002 | 14.6 Mb | ||
| Placement | 0.001 | 20.9 Mb | ||
| Operator | 0.003 | 18 Mb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the only place that we capture the Control Plane numbers and are these consistently the same for all the performance test? If so we should separate these out. If not, then should each perf test have different control plane numbers like this one?
daprdocs/content/en/operations/performance-and-scalability/perf-pubsub.md
Outdated
Show resolved
Hide resolved
type: docs | ||
title: "State performance" | ||
linkTitle: "State performance" | ||
weight: 20000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weight: 20000 | |
weight: 40000 |
Stale PR, paging all reviewers |
Stale PR, paging all reviewers |
@yaron2 friendly bump |
Stale PR, paging all reviewers |
Stale PR, paging all reviewers |
Stale PR, paging all reviewers |
Stale PR, paging all reviewers |
Stale PR, paging all reviewers |
Stale PR, paging all reviewers |
lol @msfussell @yaron2 remember this PR? should this be closed and reopened for 1.15? |
Stale PR, paging all reviewers |
Stale PR, paging all reviewers |
Stale PR, paging all reviewers |
…f-actors-activation.md Co-authored-by: Mark Fussell <[email protected]> Signed-off-by: Yaron Schneider <[email protected]>
…f-service-invocation.md Co-authored-by: Mark Fussell <[email protected]> Signed-off-by: Yaron Schneider <[email protected]>
…f-pubsub.md Co-authored-by: Mark Fussell <[email protected]> Signed-off-by: Yaron Schneider <[email protected]>
Closes #3468