Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Ninja to build llvm in the ci (osx and Ubuntu) #423

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

mcbarton
Copy link
Collaborator

@mcbarton mcbarton commented Jan 8, 2025

Description

Please include a summary of changes, motivation and context for this PR.

My local testing on an osx arm Macbook found an 35% reduction in the size of the build folder when using Ninja to build llvm. This should help reduce the pressure on the cache. Supposedly Ninja is faster so we should see a speed in the llvm build when we have to rebuild the cache. If the ci passes then all Ubuntu and MacOS builds should be cleared from the cache before merging.

Fixes # (issue)

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Requires documentation updates

Testing

Please describe the test(s) that you added and ran to verify your changes.

Checklist

  • I have read the contribution guide recently

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.85%. Comparing base (c446c3e) to head (78a655f).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #423   +/-   ##
=======================================
  Coverage   70.85%   70.85%           
=======================================
  Files           9        9           
  Lines        3538     3538           
=======================================
  Hits         2507     2507           
  Misses       1031     1031           

Copy link
Collaborator

@anutosh491 anutosh491 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think this is nice. I would have also preferred ninja for the emscripten build but I remember there were some reasons why we switched from ninja to cmake on emscripten-forge. I guess we just had some trouble using ninja. I need to try again.
Having it on osx and ubuntu is a good start.

@mcbarton
Copy link
Collaborator Author

mcbarton commented Jan 9, 2025

@anutosh491 Ninja works now. I have tried it and plan to put in another PR for the emscripten build once the deployment PR is merged.

@mcbarton mcbarton merged commit 508823a into compiler-research:main Jan 9, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants