Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cling in ci to version 1.1 using roots llvm 16 #358

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open
61 changes: 59 additions & 2 deletions .github/workflows/non-emscripten.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,15 @@ jobs:
cppyy: On
llvm_enable_projects: "clang"
llvm_targets_to_build: "host;NVPTX"
- name: ubu22-x86-gcc12-clang16-cling
os: ubuntu-22.04
compiler: gcc-12
clang-runtime: '16'
cling: On
cling-version: '1.1'
cppyy: On
llvm_enable_projects: "clang"
llvm_targets_to_build: "host;NVPTX"
- name: ubu22-x86-gcc9-clang13-cling
os: ubuntu-22.04
compiler: gcc-9
Expand Down Expand Up @@ -95,6 +104,15 @@ jobs:
cppyy: On
llvm_enable_projects: "clang"
llvm_targets_to_build: "host;NVPTX"
- name: osx15-arm-clang-clang16-cling
os: macos-15
compiler: clang
clang-runtime: '16'
cling: On
cling-version: '1.1'
cppyy: On
llvm_enable_projects: "clang"
llvm_targets_to_build: "host;NVPTX"
- name: osx15-arm-clang-clang13-cling
os: macos-15
compiler: clang
Expand Down Expand Up @@ -136,6 +154,15 @@ jobs:
cppyy: On
llvm_enable_projects: "clang"
llvm_targets_to_build: "host;NVPTX"
- name: osx13-x86-clang-clang16-cling
os: macos-13
compiler: clang
clang-runtime: '16'
cling: On
cling-version: '1.1'
cppyy: On
llvm_enable_projects: "clang"
llvm_targets_to_build: "host;NVPTX"
- name: osx13-x86-clang-clang13-cling
os: macos-13
compiler: clang
Expand Down Expand Up @@ -294,6 +321,13 @@ jobs:
git clone https://github.com/root-project/cling.git
cd ./cling
git checkout tags/v${{ matrix.cling-version }}
# Apply patches
llvm_vers=$(echo "${{ matrix.clang-runtime }}" | tr '[:lower:]' '[:upper:]')
if [[ "${llvm_vers}" == "16" ]]; then
# cling version 1.1 with llvm 16 requires a patch to fix error handling when parsing invaild code
git apply -v ../patches/llvm/cling${{ matrix.clang-runtime }}-*.patch
echo "Apply cling${{ matrix.clang-runtime }}-*.patch patches:"
fi
cd ..
git clone --depth=1 -b cling-llvm${{ matrix.clang-runtime }} https://github.com/root-project/llvm-project.git
else # repl
Expand All @@ -320,8 +354,10 @@ jobs:
../llvm
cmake --build . --target clang --parallel ${{ env.ncpus }}
cmake --build . --target cling --parallel ${{ env.ncpus }}
# Now build gtest.a and gtest_main for CppInterOp to run its tests.
cmake --build . --target gtest_main --parallel ${{ env.ncpus }}
if [[ "${{ matrix.clang-runtime}}" == "13" ]]; then
# Now build gtest.a and gtest_main for CppInterOp to run its tests.
cmake --build . --target gtest_main --parallel ${{ env.ncpus }}
fi
else
# Apply patches
llvm_vers=$(echo "${{ matrix.clang-runtime }}" | tr '[:lower:]' '[:upper:]')
Expand Down Expand Up @@ -410,6 +446,13 @@ jobs:
clang-runtime: '16'
cling: Off
cppyy: Off
- name: ubu22-x86-gcc12-clang16-cling
os: ubuntu-22.04
compiler: gcc-12
clang-runtime: '16'
cling: On
cling-version: '1.1'
cppyy: Off
- name: ubu22-x86-gcc9-clang13-cling-cppyy
os: ubuntu-22.04
compiler: gcc-9
Expand Down Expand Up @@ -441,6 +484,13 @@ jobs:
clang-runtime: '16'
cling: Off
cppyy: Off
- name: osx15-arm-clang-clang16-cling
os: macos-15
compiler: clang
clang-runtime: '16'
cling: On
cling-version: '1.1'
cppyy: Off
- name: osx15-arm-clang-clang13-cling-cppyy
os: macos-15
compiler: clang
Expand Down Expand Up @@ -472,6 +522,13 @@ jobs:
clang-runtime: '16'
cling: Off
cppyy: Off
- name: osx13-x86-clang-clang16-cling
os: macos-13
compiler: clang
clang-runtime: '16'
cling: On
cling-version: '1.1'
cppyy: Off
- name: osx13-x86-clang-clang13-cling-cppyy
os: macos-13
compiler: clang
Expand Down
17 changes: 17 additions & 0 deletions patches/llvm/cling16-1-Error-Handling.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
diff --git a/lib/Interpreter/IncrementalParser.cpp b/lib/Interpreter/IncrementalParser.cpp
index 89cd78d..2aea40d 100644
--- a/lib/Interpreter/IncrementalParser.cpp
+++ b/lib/Interpreter/IncrementalParser.cpp
@@ -911,8 +911,11 @@ namespace cling {
PP.EnterSourceFile(FID, /*DirLookup*/nullptr, NewLoc);
m_Consumer->getTransaction()->setBufferFID(FID);

- if (!ParseOrWrapTopLevelDecl())
+ llvm::Expected<bool> res = ParseOrWrapTopLevelDecl();
+ if (!res) {
+ llvm::consumeError(std::move(res.takeError()));
return kFailed;
+ }

if (PP.getLangOpts().DelayedTemplateParsing) {
// Microsoft-specific:
12 changes: 10 additions & 2 deletions unittests/CppInterOp/CUDATest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,10 @@ using namespace TestUtils;

static bool HasCudaSDK() {
auto supportsCudaSDK = []() {
#if CLANG_VERSION_MAJOR < 16
#ifdef USE_CLING
// FIXME: Enable this for cling.
return false;
#elif CLANG_VERSION_MAJOR < 16
// FIXME: Enable this for cling.
return false;
#endif // CLANG_VERSION_MAJOR < 16
Expand All @@ -23,7 +26,10 @@ static bool HasCudaSDK() {

static bool HasCudaRuntime() {
auto supportsCuda = []() {
#if CLANG_VERSION_MAJOR < 16
#ifdef USE_CLING
// FIXME: Enable this for cling.
return false;
#elif CLANG_VERSION_MAJOR < 16
// FIXME: Enable this for cling.
return false;
#endif //CLANG_VERSION_MAJOR < 16
Expand All @@ -43,6 +49,8 @@ static bool HasCudaRuntime() {

#if CLANG_VERSION_MAJOR < 16
TEST(DISABLED_CUDATest, Sanity) {
#elif USE_CLING
TEST(DISABLED_CUDATest, Sanity) {
#else
TEST(CUDATest, Sanity) {
#endif // CLANG_VERSION_MAJOR < 16
Expand Down
Loading