cEP-0016.md: Commit Content Inspection #114

kriti21 · 2018-05-03T12:12:17Z

This cEP the coala process rules which
will be enforced by GitCommitBear to handle
special types of commit messages like
git revert and git merge.

refeed · 2018-05-05T15:06:39Z

cEP-0016.md

+        encoding = diff.headers.getparam('charset')
+
+        patch1 = PatchSet(diff1, encoding=encoding)
+        patch2 = PatchSet(diff1, encoding=encoding)


Did you mean diff2 ?

refeed · 2018-05-05T15:09:29Z

cEP-0016.md

+        patch2 = PatchSet(diff1, encoding=encoding)
+
+        # compare patch1 and patch2 using unidiff
+        if not(patch1) == patch2:


I think practically probably we wanna do if not patch1 == patch2: (without the parentheses). However, this is just a draft, so it doesn't matter here ;)

refeed · 2018-05-05T15:24:56Z

cEP-0016.md

@@ -0,0 +1,178 @@
+Commit Content Inspection


Shouldn't it be "Git Commit Content Inspection" ?

refeed · 2018-05-06T00:08:28Z

cEP-0016.md

+| Status       | Implementation due                         |
+| Type         | Process                                    |
+
+# Abstract


I think we can change this "Header 1" title to a "Heading 2" title (## Abstract)
and also change the "Header 1" which are below this line

"Header 1" is usually just used once and it just used for the title of the document itself.

palash25 · 2018-05-07T07:55:31Z

cEP-0016.md

+This document describes coala process rules which will be enforced by the
+GitCommitBear.
+
+This cEP describes some new changes in the implementation of GitCommitBear


Why do we have "this document describes" twice? It sounds weird while reading it. Can't you just write it in one paragraph?

Like "This document describes coala process rules which will be enforced by the GitCommitBear and some new changes in its implementation.........."

palash25 · 2018-05-07T07:56:39Z

cEP-0016.md

+
+The GitCommitBear at present performs a check on the content of regular commits
+made to coala. However, there are many special types of commit messages that
+should be only used in conjunction with patches containing a special type of


should be only used -> should only be used

seblat

Looks fine to me regarding the comments which have already been made

jayvdb · 2018-05-08T02:13:00Z

cEP-0016.md

+Here is the detailed implementation stepwise:
+
+1. We start by identifying different types of special commits namely revert,
+merge and travis commits.


indent.

also please run a markdown validator on your file.

#128 will enforce this.

damngamerz

LGTM :)
Well done on the mockups.

jayvdb · 2018-05-09T03:40:42Z

cEP-0016.md

+2. Each type of commit is then handled as a separate case.
+3. For travis commits:
+    * Merged commits are identified first.
+    * It's checked whether the merge commit contains `[ci skip]`.


no. [ci skip] is not a 'travis commit'

Please read more about [ci skip]

refeed

lgtm

refeed · 2018-07-12T01:44:03Z

cEP-0016.md

+     it is not a clean revert is expected.
+   - A message suggesting improvements in the commit message is displayed.
+
+## Code Prototypes


I think we might want to get rid of this section since it changes everytime the PR for VCSCommitBear updated, and it blocks this cEP to get merged faster. The explanation above is good enough imo :)

refeed · 2018-07-12T01:51:21Z

cEP-0016.md

+   corresponding CI engine allows skipping build or not. An appropriate message
+   is returned if skipping build is not supported.
+   - If the commit type from the output of `VCSCommitBear` indicates that the
+     commit skips CI build, inspection is done inside `CISkipInspectBear`


Also update this, VCSCommitBear is no longer providing COMMIT_TYPE.ci_skip_commit, all of the matching is done inside of the CISkipInspectBear.

refeed · 2018-07-12T01:51:38Z

cEP-0016.md

+     perform a `git rebase` instead.
+7. For revert commits:
+   - If the commit type from the output of `VCSCommitBear` indicates that the
+     commit is a `git revert` commit, inspection is done in


Update this also

refeed · 2018-07-12T06:56:51Z

cEP-0016.md

+   - If the commit type from the output of `VCSCommitBear` indicates that the
+     commit is a `git merge` commit, inspection is done in `GitMergeInspectBear`
+     otherwise return.
+   - `GitMergeInspectBear` will be used by find if the commit tries to merge


by find

by finding

refeed · 2018-07-12T06:57:02Z

cEP-0016.md

+   - `GitCommitBear` would identify and check contents of the unmerged parent of
+     these merge commits.
+4. A meta bear called `VCSCommitBear` would be created that would return a
+   `HiddenResult` comprising of a tuple that will contain information about


HiddenResult

CommitResult

jayvdb · 2018-07-28T20:18:57Z

ack 386ddb3

jayvdb · 2018-07-28T20:19:21Z

@gitmate-bot rebase

gitmate-bot · 2018-07-28T20:19:23Z

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

This cEP describes the coala process rules which will be enforced to handle special types of commit messages like git revert and git merge. Closes coala#112

gitmate-bot · 2018-07-28T20:20:27Z

Automated rebase with GitMate.io was successful! 🎉

jayvdb · 2018-07-28T20:34:08Z

@gitmate-bot ff

gitmate-bot · 2018-07-28T20:34:14Z

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently ⚠️

gitmate-bot · 2018-07-28T20:35:23Z

Automated fastforward with GitMate.io was successful! 🎉

gitmate-bot added process/pending review size/S enhancement labels May 3, 2018

kriti21 force-pushed the cEPgsoc18 branch from 9dfb94d to e6ea393 Compare May 3, 2018 12:15

jayvdb requested review from guyzmo, damngamerz, seblat and refeed May 4, 2018 04:30

kriti21 force-pushed the cEPgsoc18 branch 2 times, most recently from 7b803cf to af35d6f Compare May 4, 2018 18:23

refeed reviewed May 5, 2018

View reviewed changes

cEP-0016.md Outdated

@@ -0,0 +1,178 @@

Commit Content Inspection

Copy link

Member

refeed May 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be "Git Commit Content Inspection" ?

kriti21 force-pushed the cEPgsoc18 branch from af35d6f to bb45e20 Compare May 5, 2018 18:08

refeed reviewed May 6, 2018

View reviewed changes

kriti21 force-pushed the cEPgsoc18 branch 2 times, most recently from bc9703c to 20d86e5 Compare May 6, 2018 04:22

gitmate-bot added New cEP and removed enhancement labels May 7, 2018

palash25 reviewed May 7, 2018

View reviewed changes

seblat approved these changes May 7, 2018

View reviewed changes

kriti21 force-pushed the cEPgsoc18 branch from 20d86e5 to 54314bb Compare May 7, 2018 14:56

jayvdb requested changes May 8, 2018

View reviewed changes

jayvdb added process/wip and removed process/pending review labels May 8, 2018

damngamerz approved these changes May 8, 2018

View reviewed changes

jayvdb added the status/blocked label May 9, 2018

jayvdb requested changes May 9, 2018

View reviewed changes

kriti21 force-pushed the cEPgsoc18 branch from 54314bb to 46b8378 Compare May 9, 2018 12:12

gitmate-bot removed the process/wip label May 9, 2018

kriti21 force-pushed the cEPgsoc18 branch from 4e07533 to ea72712 Compare July 9, 2018 08:45

refeed approved these changes Jul 9, 2018

View reviewed changes

kriti21 force-pushed the cEPgsoc18 branch 3 times, most recently from a83ea49 to bb414fe Compare July 11, 2018 23:22

refeed reviewed Jul 12, 2018

View reviewed changes

kriti21 force-pushed the cEPgsoc18 branch from bb414fe to 335d0e2 Compare July 12, 2018 02:10

gitmate-bot added size/S and removed size/M labels Jul 12, 2018

refeed reviewed Jul 12, 2018

View reviewed changes

kriti21 force-pushed the cEPgsoc18 branch from 335d0e2 to 386ddb3 Compare July 12, 2018 07:17

gitmate-bot added the status/STALE label Jul 15, 2018

jayvdb approved these changes Jul 28, 2018

View reviewed changes

gitmate-bot added process/approved and removed process/pending review labels Jul 28, 2018

cEP-0016.md: Commit Content Inspection

ea25f09

This cEP describes the coala process rules which will be enforced to handle special types of commit messages like git revert and git merge. Closes coala#112

gitmate-bot force-pushed the cEPgsoc18 branch from 386ddb3 to ea25f09 Compare July 28, 2018 20:20

gitmate-bot added the process/pending review label Jul 28, 2018

gitmate-bot added process/approved and removed process/approved status/STALE process/pending review labels Jul 28, 2018

gitmate-bot merged commit ea25f09 into coala:master Jul 28, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cEP-0016.md: Commit Content Inspection #114

cEP-0016.md: Commit Content Inspection #114

kriti21 commented May 3, 2018

refeed May 5, 2018

refeed May 5, 2018 •

edited

Loading

refeed May 5, 2018

refeed May 6, 2018 •

edited

Loading

kriti21 May 6, 2018

palash25 May 7, 2018

palash25 May 7, 2018

seblat left a comment

jayvdb May 8, 2018

jayvdb May 9, 2018

damngamerz left a comment

jayvdb May 9, 2018

refeed left a comment

refeed Jul 12, 2018

refeed Jul 12, 2018

refeed Jul 12, 2018

refeed Jul 12, 2018

refeed Jul 12, 2018

jayvdb commented Jul 28, 2018

jayvdb commented Jul 28, 2018

gitmate-bot commented Jul 28, 2018

gitmate-bot commented Jul 28, 2018

jayvdb commented Jul 28, 2018

gitmate-bot commented Jul 28, 2018

gitmate-bot commented Jul 28, 2018

cEP-0016.md: Commit Content Inspection #114

cEP-0016.md: Commit Content Inspection #114

Conversation

kriti21 commented May 3, 2018

Choose a reason for hiding this comment

refeed May 5, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

refeed May 6, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

seblat left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

damngamerz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

refeed left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jayvdb commented Jul 28, 2018

jayvdb commented Jul 28, 2018

gitmate-bot commented Jul 28, 2018

gitmate-bot commented Jul 28, 2018

jayvdb commented Jul 28, 2018

gitmate-bot commented Jul 28, 2018

gitmate-bot commented Jul 28, 2018

refeed May 5, 2018 •

edited

Loading

refeed May 6, 2018 •

edited

Loading